Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to import folders #3086

Open
wants to merge 1 commit into
base: disambiguateimport
Choose a base branch
from
Open

Allow to import folders #3086

wants to merge 1 commit into from

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented Jun 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
feature

What is the current behavior?
impossible to import all files in a folder, and impossible to import files in a folder that don't have the same basename as the folder

What is the new behavior (if this is a feature change)?
possible

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@annetill
Copy link
Member

Hi @jonenst, for me it is not a use case. If this feature is for CGMES users, we don't need it. The current design, where we load in triple store, is working fine and the community is used to it. I think that we don't have to create new use cases with datasource, just fix the current ones.

Copy link

sonarcloud bot commented Jul 4, 2024

@jonenst jonenst mentioned this pull request Jul 5, 2024
5 tasks
@jonenst jonenst changed the base branch from disambiguateimport to main July 15, 2024 16:09
@jonenst jonenst changed the base branch from main to disambiguateimport July 15, 2024 16:09
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants