Replace CGMES.switchType property by CGMES.originalClass property. #3267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
Refactoring.
What is the current behavior?
At CGMES import, if the Switch kind doesn't have a direct map to IIDM, i.e. if its class is: Switch, ProtectedSwitch, GroundDisconnector, Jumper, then its CGMES original class is stored in a CGMES.switchType property. The purpose is to be able to export back to CGMES the object with the correct class.
Similarly, at CGMES import, the original CGMES class of load or generator is stored in a CGMES.originalClass property.
What is the new behavior (if this is a feature change)?
For consistency purposes, drop the use of CGMES.switchType property in favor of CGMES.originalClass.
Does this PR introduce a breaking change or deprecate an API?*
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Any access to the
CGMES.switchType
property should be replaced withCGMES.originalClass
property. For instance:should be replaced by:
Similarly, any network saved to a serialized IIDM file should be updated by replacing all occurences of
CGMES.switchType
withCGMES.originalClass
property, in case the network needs to be exported to CGMES.Other information: