Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special method declaration order #311

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix special method declaration order #311

wants to merge 14 commits into from

Conversation

mathbagu
Copy link

@mathbagu mathbagu commented Apr 9, 2021 •
edited by sebalaig
Loading

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
#312

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Coding style

What is the current behavior? (You can also link to an open issue here)
The copy and move constructors are declared after the destructor

What is the new behavior (if this is a feature change)?
The copy and move constructors are declared before the destructor, with other contructors

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@mathbagu mathbagu requested a review from sebalaig April 9, 2021 10:45
sebalaig
sebalaig requested changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@sebalaig sebalaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the following files should also be updated:

  • ExtensionAdder.hpp
  • SlackTerminalAdder.hpp

Additional/related inconsistencies:

  • Destructor is declared twice in SwitchAdder

@mathbagu
Copy link
Author

mathbagu commented Apr 9, 2021

@sebalaig I don't understand your last comment. Do you run a script and miss that the SwitchAdder is declared twice, one time for each kind of view?

@mathbagu mathbagu changed the title Fix special method declaration order WIP: Fix special method declaration order Apr 9, 2021
@sebalaig
Copy link
Contributor

sebalaig commented Apr 9, 2021

@sebalaig I don't understand your last comment. Do you run a script and miss that the SwitchAdder is declared twice, one time for each kind of view?

You're right, I did not check they were in different classes :/

@sebalaig sebalaig linked an issue Apr 9, 2021 that may be closed by this pull request
Fix special functions order #312
Open
@mathbagu mathbagu changed the base branch from integration/v1.4.0 to integration/v1.5.0 April 12, 2021 10:11
@sebalaig @mathbagu
Update version to 1.5 (#290)
536e7ff 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig sebalaig force-pushed the fix-special-method-declaration-order branch from 58e1660 to 4d6ab66 Compare April 13, 2021 08:54
@sebalaig sebalaig self-requested a review April 13, 2021 08:54
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

sebalaig and others added 13 commits April 13, 2021 19:32
@sebalaig
[IIDM v1.5] Removed deprecated NetworkXmlWriterContext::getExtensionW…
fa59a54 
…riter (#279) (#301)

* Removed deprecated NetworkXmlWriterContext::getExtensionWriter (#279)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Co-authored-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig @mathbagu
Fix bad string format in error message (#313)
1e366f3 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig
Add Boundary concept for HalfLine and DanglingLine (#291) (#306)
e1f8fb1 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig
Add Kosovo (#293) (#320)
99d4c39 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig
Add missing invalidateCache in N/B Voltage Level (#318) (#319)
14e6ba6 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig
Fix multiple connect/disconnect in NodeBreakerVoltageLevel to avoid u…
6b49d25 
…nwanted topology change (#285) (#324)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@gautierbureau
Fix example2 CMakeLists with new thread package requirement. (#326)
5cc4bf3 
Signed-off-by: Gautier Bureau <gautier.bureau@gmail.com>
@sebalaig
Throw a comprehensive exception when a terminal ref of a busbar secti…
ab77139 
…on on is written in bus-breaker or bus-branch (#295) (#323)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig
Fix missing licence header (#321) (#325)
24f67dd 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig @mathbagu
Invalidate ConnectedComponentsManager and SynchronousComponentsManage…
e12c1a1 
…r in NodeBreakerVoltageLevel::invalidateCache()

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig
Fix special method declaration order
6be8e15 
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig
Fix special method declaration order
87159f8 
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
@sebalaig
Fix missing
5f5e185 
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig sebalaig force-pushed the fix-special-method-declaration-order branch from 4d6ab66 to 5f5e185 Compare June 21, 2021 08:00
sebalaig
sebalaig approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@sebalaig sebalaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathbagu I added a few changes right now. It's ok for me now.

@sebalaig sebalaig changed the title WIP: Fix special method declaration order Fix special method declaration order Jun 21, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

Base automatically changed from integration/v1.5.0 to main January 10, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalaig sebalaig sebalaig approved these changes

Assignees
No one assigned
Labels
PR: waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix special functions order
3 participants
@mathbagu @sebalaig @gautierbureau