Add DanglingLineData and TwtData (#379) #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalaig
force-pushed
the
issue379-vAndAngle
branch
from
6ed23d1
to
0b44f0a
Compare
sebalaig
force-pushed
the
issue379-vAndAngle
branch
from
0b44f0a
to
ecfd366
Compare
sebalaig
changed the title
sebalaig
force-pushed
the
issue379-vAndAngle
branch
from
ecfd366
to
22b9d7d
Compare
mathbagu
requested changes
May 23, 2022
| m_ratedU0(twt.getRatedU0()) { | ||
| m_rho1 = rho(twt.getLeg1(), m_ratedU0); | ||
| m_rho2 = rho(twt.getLeg2(), m_ratedU0); | ||
| m_rho3 = rho(twt.getLeg3(), m_ratedU0); |
There was a problem hiding this comment.
Why these variables are not initialized in the initialization list?
There was a problem hiding this comment.
Because m_ratedU0 needs to be initialized, and we cannot initialize m_rho1 in initializer list after m_ratedU0 without having a compiler warning. The solution could be to reorder attributes so that m_rho{1,2,3} are declared after m_ratedU0 ?
There was a problem hiding this comment.
No need to use m_rated0 because it’s equivalent to twt.getRated0()
There was a problem hiding this comment.
Yes it is needed because it is returned by TwtData::getRatedU0()
… implementation to use it Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
sebalaig
force-pushed
the
issue379-vAndAngle
branch
from
22b9d7d
to
ffa4c16
Compare
sebalaig
added
PR: waiting-for-info-reviewer
PR: waiting-for-review
and removed
PR: waiting-for-correction
labels
|
Kudos, SonarCloud Quality Gate passed! |
mathbagu
added
PR: waiting-for-info-general
and removed
PR: waiting-for-info-reviewer
labels
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restCloses #379
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)