Upgrade to react-map-gl 7 to use maplibre to allow usage without mapb… #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gridstudy-app) Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
Signed-off-by: Florent MILLOT <millotflo@gmail.com>
…ox token and other tile sources deckgl needs 8.9.18+ according to react-map-gl docs https://visgl.github.io/react-map-gl/docs/upgrade-guide#upgrading-to-v71 "If you use the Map component as a child of the DeckGL component from deck.gl, upgrade deck.gl to >=8.9.18." Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
flomillot
reviewed
Oct 27, 2023
| @@ -28,6 +28,42 @@ module.exports = { | |||
| ] | |||
| }, | |||
| resolve: { | |||
| //XXX why is this needed ? | |||
| // ERROR in ./node_modules/react-map-gl/dist/esm/exports-mapbox.js 16:15-34 | |||
flo-dup
force-pushed
the
network_map_viewer
branch
from
e35d3cd
to
ff65106
Compare
flo-dup
force-pushed
the
main
branch
2 times, most recently
from
90b0859
to
58f6214
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
NO
What kind of change does this PR introduce?
feature
What is the current behavior?
network-map-viewer requires mapboxtoken
What is the new behavior (if this is a feature change)?
no more mapbox token: maplibre 3, react-map-gl 7, deckgl 8.9.18+
Does this PR introduce a breaking change or deprecate an API?
Breaks navigation control, didn't have time to fix it