prepares the removal of the testMove1NbNetwork and testMove2Nb overrides #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
5 tasks
EtienneLt
approved these changes
Sep 17, 2024
Signed-off-by: Mathieu DEHARBE <mathieu.deharbe@rte-france.com>
|
Mathieu-Deharbe
deleted the
corrects-testMove1NbNetwork-and-testMove1NbNetwork
branch
Mathieu-Deharbe
changed the title
Mathieu-Deharbe
changed the title
Mathieu-Deharbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Takes in accoiunt the changes that have been made into powsybl network store here powsybl/powsybl-network-store#447. In order to correct the testMove1NbNetwork and testMove1NbNetwork tests. Those had been overriden by empty functions. Once powsybl network store server uses the network store last version, those tests will work and the overriden empty functions may be removed.
Does this PR introduce a breaking change or deprecate an API?