Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies #349

Merged
merged 22 commits into from
Oct 30, 2023
Merged

Dependencies #349

merged 22 commits into from
Oct 30, 2023

Conversation

AbdelHedhili
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
powsybl dependencies 2023.3.1

BOUTIER Charly and others added 10 commits August 1, 2023 10:21
Adds equipment information on problematic VSC and Busbar index in err…
0e47169 
…or messages

Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Fixes unit tests
9ade47a 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
Fixes coverage
05074ac 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
PR Review
c060ade 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
PR Review
0c576a1 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish
Merge branch 'main' into add_equipment_id_in_throw_message
c542654
PR Review
cd63fa6 
Signed-off-by: BOUTIER Charly <charly.boutier@rte-france.com>
@EstherDarkish
Merge pull request #343 from powsybl/add_equipment_id_in_throw_message
9bcf231 
Adds equipment information on problematic VSC and Busbar index
@AbdelHedhili
Merge branch 'main' of https://github.com/powsybl/powsybl-network-store…
e1b3062 
… into main
@AbdelHedhili
powsybl dependencies 2023.3.1
ee75b0b 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili AbdelHedhili self-assigned this Oct 23, 2023
@AbdelHedhili
put tests back
db0ee4c 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@AbdelHedhili
Copy link
Member Author

There is still a bug to fix that can be visualized through the TieLineTest test class

antoinebhs
antoinebhs reviewed Oct 25, 2023
View reviewed changes
...-store-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/tck/MergeNetworkTest.java Outdated Show resolved Hide resolved
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/DanglingLineImpl.java Outdated Show resolved Hide resolved
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NetworkImpl.java
public BusView getBusView() {
return busView;
public Iterable<VoltageAngleLimit> getVoltageAngleLimits() {
return new ArrayList<>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not throw "TODO" everywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it'll break things that used to work that now go through these methods (for exemple cgmes export)

@etiennehomer etiennehomer self-requested a review October 25, 2023 13:53
etiennehomer
etiennehomer reviewed Oct 25, 2023
View reviewed changes
...-store-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/tck/MergeNetworkTest.java Outdated
//FIXME
}

@Test
Copy link
Contributor

@etiennehomer etiennehomer Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a problem that those methods are package private in powsybl-core nope ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see what the problem would be ?

antoinebhs
antoinebhs reviewed Oct 25, 2023
View reviewed changes
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
...k-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/NodeBreakerViewImpl.java Outdated Show resolved Hide resolved
antoinebhs
antoinebhs requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve BFS implementation and fix compilation error in MergeNetworkTest.

etiennehomer
etiennehomer reviewed Oct 26, 2023
View reviewed changes
network-store-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TieLineImpl.java
var resource = getResource();

index.notifyBeforeRemoval(this);

if (updateDanglingLines) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this code if it doesn't work. And we implement it later

antoinebhs and others added 4 commits October 27, 2023 14:46
@antoinebhs
split traverse in two methods: DFS/BFS
6d9e58c 
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
@AbdelHedhili @antoinebhs
review fixes
dba9679 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
@antoinebhs
Temporary fix for PowSyBl 2023.3, get dangling lines from network.
6cca14e 
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
@antoinebhs
Temporary fix for PowSyBl 2023.3, get dangling lines from network.
52505c0 
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
antoinebhs and others added 2 commits October 27, 2023 17:24
@antoinebhs
Temporary fix for PowSyBl 2023.3, get dangling lines from network.
4ea980e 
Signed-off-by: BOUHOURS Antoine <antoine.bouhours@rte-france.com>
@AbdelHedhili
Merge branch 'main' into dependencies
053dca5 
Signed-off-by: Abdelsalem <46495975+AbdelHedhili@users.noreply.github.com>
@AbdelHedhili
Merge branch 'dependencies' of https://github.com/powsybl/powsybl-net…
e6ad144 
…work-store into dependencies
@AbdelHedhili
remove updateDanglingline
111031b 
Signed-off-by: Abdelsalem <abdelsalem.hedhili@rte-france.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

69.8% 69.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@etiennehomer etiennehomer merged commit 22e68e6 into main Oct 30, 2023
4 of 5 checks passed
@etiennehomer etiennehomer deleted the dependencies branch October 30, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennehomer etiennehomer etiennehomer approved these changes

@antoinebhs antoinebhs antoinebhs approved these changes

Assignees

@AbdelHedhili AbdelHedhili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbdelHedhili @etiennehomer @antoinebhs @EstherDarkish