Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC security analysis: RHS is not invalidated #1042

Merged
merged 2 commits into from
Jun 10, 2024
Merged

DC security analysis: RHS is not invalidated #1042

merged 2 commits into from
Jun 10, 2024

Conversation

annetill
Copy link
Member

@annetill annetill commented Jun 4, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes, powsybl/pypowsybl#758

What kind of change does this PR introduce?

Nothing for the moment, just a unit test that shows the bug. In DC security analysis only, equations can have rhs. If the rhs of these equations changed, because in contingency for example, but it could be a tap position change of a P0 change for HVDC, we have to invalidate the DC target vector. It is not the case on main branch.

We have the issue just today because it was hidden before through the sensitivity analysis API.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Copy link
Collaborator

@vidaldid-rte vidaldid-rte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Maybe you could add a similar test for AC (although it should logically not be subject to this bug)

Copy link

sonarcloud bot commented Jun 10, 2024

@geofjamg geofjamg merged commit d91090b into main Jun 10, 2024
5 checks passed
@geofjamg geofjamg deleted the as_dc_rhs branch June 10, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants