-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computing Hvdc line loss in AC emulation #1062
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
67346d7
Added HVDC line loss in AC emulation
SylvestreSakti 7b60f08
Added newline for checkstyle
SylvestreSakti a15c4e7
Added newline for checkstyle
SylvestreSakti f6c740b
Modified tests to keep same behaviour with HVDC line resistance in AC…
SylvestreSakti cf2eb5f
Keeps r in ohms and its getter returns value in per unit
SylvestreSakti fba1fc4
Modified implementation of line losses with the method getHvdcLineLosses
SylvestreSakti ba21575
Added FIXME comment to use HvdcUtils.getHvdcLineLosses() from powsybl…
SylvestreSakti 86189c4
Modified one test to check the correct sign of the influence of R in …
SylvestreSakti a7e9dac
Checkstyle corrections
SylvestreSakti b6707f5
Added comments to explain test of difference between R=0 and R!=0
SylvestreSakti 65069d7
Use of HvdcUtils.getHvdcLineLosses with new release of powsybl-core
SylvestreSakti 90809f6
Fixed for checkstyle
SylvestreSakti 35bdfbb
Merge branch 'main' into hvdc-line-loss-ac-emulation
annetill 860ee50
Modified to have more common code in AbstractHvdcAcEmulationFlowEquat…
SylvestreSakti e9cb339
Fixed tests to take cable loss into account
SylvestreSakti a2fb18c
Changed signs to avoid confusion
SylvestreSakti 74dface
Added assert to check sign of powers
SylvestreSakti 50ecc4d
Rename methods and added comments
SylvestreSakti 8c2af3f
Fixed error in checking sign of losses
SylvestreSakti 423aeeb
Merge branch 'main' into hvdc-line-loss-ac-emulation
annetill b8dc6dd
Removed unused line
SylvestreSakti 6fc2c5a
Renamed variables
SylvestreSakti 47a137e
Renamed variable for better comprehension
SylvestreSakti e8fd904
Changed boundedP to rawP in checking controller station
SylvestreSakti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the check isController from rawP to boundedP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because isController() only checks the sign of the power transit. I thought there was no need to store rawP instead of directly checking the sign of boundedP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is equivalent but as Didier is not here (these lines about boundedP are from him) maybe keep former lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is equivalent (unless bounds of P are negative which they shouldn't). But I modified in order to keep the former lines.