Add new method withNetworkElement for InjectionRangeActionAdder #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangjer <jeremy.wang@rte-france.com>
pet-mit
reviewed
Jul 9, 2024
Comment on lines
134
to
135
| .withNetworkElement(injectionId1) | ||
| .withNetworkElement(injectionId2, injectionName2) |
There was a problem hiding this comment.
I wonder if we want this to add both elements with key = 1, or only the last added element (i.e. injectionId2), with key = 1. what do you think @phiedw ?
There was a problem hiding this comment.
I would say if you call withNetworkElement you should only be able to call it once (calling it more would throw an error telling you to call withNetworkElementAndKey if you want to add multiple injections).
There was a problem hiding this comment.
@wangjer can you please update the branch following these comments?
pet-mit
added
next-release
Signed-off-by: wangjer <jeremy.wang@rte-france.com>
Signed-off-by: wangjer <jeremy.wang@rte-france.com>
phiedw
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
Adding a new network element to an "InjectionRangeAction" requires to use "withNetworkElementAndKey" method.
What is the new behavior (if this is a feature change)?
We can now use withNetworkElement method instead, so that "key" argument is set to 1.0 by default
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: