Add configuration of reactive slacks repartition #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode. Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy
changed the title
Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy
changed the title
p-arvy
changed the title
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
p-arvy
changed the title
klorel
reviewed
Nov 23, 2023
Signed-off-by: parvy <pierre.arvy@artelys.com>
# Conflicts: # open-reac/src/main/java/com/powsybl/openreac/parameters/input/OpenReacParameters.java # open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersDeserializer.java # open-reac/src/main/java/com/powsybl/openreac/parameters/input/json/OpenReacParametersSerializer.java # open-reac/src/test/java/com/powsybl/openreac/OpenReacParametersTest.java # open-reac/src/test/java/com/powsybl/openreac/OpenReacRunnerTest.java # open-reac/src/test/java/com/powsybl/openreac/parameters/input/json/OpenReacJsonModuleTest.java # open-reac/src/test/resources/expected_inputs/param_algo.txt # open-reac/src/test/resources/expected_inputs/param_buses_with_reactive_slack.txt # open-reac/src/test/resources/openreac-output-ieee14/reactiveopf_results_indic.txt # open-reac/src/test/resources/openreac-output-real-network/reactiveopf_results_generators.csv # open-reac/src/test/resources/openreac-output-real-network/reactiveopf_results_indic.txt # open-reac/src/test/resources/openreac-output-shunt/reactiveopf_results_indic.txt # open-reac/src/test/resources/openreac-output-shunt/reactiveopf_results_shunts.csv # open-reac/src/test/resources/openreac-output-svc/reactiveopf_results_indic.txt # open-reac/src/test/resources/openreac-output-transfo/reactiveopf_results_generators.csv # open-reac/src/test/resources/openreac-output-transfo/reactiveopf_results_indic.txt # open-reac/src/test/resources/openreac-output-vsc/reactiveopf_results_indic.txt # open-reac/src/test/resources/parameters.json
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
Signed-off-by: parvy <pierre.arvy@artelys.com>
annetill
reviewed
Nov 24, 2023
| @@ -0,0 +1,3 @@ | |||
| #amplId powsyblId | |||
There was a problem hiding this comment.
powsyblId :-) everything here is powsybl
There was a problem hiding this comment.
I agree with this. We have to change the write function of AbstractElementInput class then :)
"#num id" would be consistent with other input/output AMPL files. Do you agree ?
There was a problem hiding this comment.
If it is in core, it is too late...
annetill
reviewed
Nov 24, 2023
| @@ -190,6 +200,15 @@ public OpenReacParameters setMaxPlausibleHighVoltageLimit(double maxPlausibleHig | |||
| return this; | |||
| } | |||
|
|
|||
| public OpenReacBusesWithReactiveSlackConfig getBusesWithReactiveSlackConfig() { | |||
Signed-off-by: parvy <pierre.arvy@artelys.com>
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Nov 27, 2023
annetill
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
#20
What kind of change does this PR introduce?
The high limit on reactive slack variables is removed. Slacks are now at each node of the network.
What is the current behavior?
The reactive slack variables have upper bound = 500 MVar. Only buses without generator, vsc and svc have reactive slacks.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
Other information: