[WIP] GraalVM JDK 21 #669
Open
[WIP] GraalVM JDK 21 #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
EtienneLt
reviewed
Nov 2, 2023
| @@ -61,9 +61,9 @@ | |||
| <version>1.1.0-SNAPSHOT</version> | |||
|
|
|||
| <properties> | |||
| <java.version>17</java.version> | |||
| <java.version>21</java.version> | |||
There was a problem hiding this comment.
no problem with maven version ?
There was a problem hiding this comment.
We will revert this to 17 in this pr to keep java 17 source compatibility, even using jdk 21
# Conflicts: # README.md
# Conflicts: # cpp/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
JDK version update
What is the current behavior?
In order to use '--pgo-instrument -H:+ProfilingEnableProfileDumpHooks' to instrument for PGO a shared library we need to upgrade to JDK 21. This is not supported with JDK 17.
But there is an issue in JDK 21 that does not allow to use native image with the class path oracle/graal#7712. So we need to wait for a fix or a workaround.
Another issue that have to be solved for upgrading to JDK21: oracle/graal#7759
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
Other information: