Fix multi substation sld svg #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
HugoKulesza
added a commit
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com> Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
write_matrix_multi_substation_single_line_diagram_svgandget_matrix_multi_substation_single_line_diagram: errors are raised depending on the matrix_ids parameter (the 2D list of substation ids);Tests were added to demonstrate the issue in a couple of cases.
On the java side the matrix's size, decoded from the python parameter, does not seem to be computed correctly.
What is the new behavior (if this is a feature change)?
The matrix's size on the Java side is computed correctly.
Does this PR introduce a breaking change or deprecate an API?