Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC runtime binaries incompatibility issues #803

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

obrix
Copy link
Member

@obrix obrix commented Jul 12, 2024

Add MT flag and define _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR as a failsafe.

See actions/runner-images#10004 (comment) for detailed information on issue.
and https://developercommunity.visualstudio.com/t/Access-violation-in-_Thrd_yield-after-up/10664660#T-N10669129-N10678728

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…safe.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix requested a review from HugoKulesza July 12, 2024 13:19
@jeandemanged jeandemanged linked an issue Jul 12, 2024 that may be closed by this pull request
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Copy link
Member

@geofjamg geofjamg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this fix and release a corrective version 1.6.1

@HugoKulesza HugoKulesza merged commit c4c5ea5 into main Jul 15, 2024
6 checks passed
@HugoKulesza HugoKulesza deleted the fix_msvc_runtime_binaries_incompatibility_issue branch July 15, 2024 13:10
HugoKulesza pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pypowsybl crashes python kernel on import
3 participants