Create "Tech Maps" Stub #3774
Merged
Create "Tech Maps" Stub #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a stub for the term "Tech map" Got distracted by Clayton's twitter so this took longer than it should've.
thanks to Nivalyx for the help on the defintion
this is very much a wip
|
Hey @paper-toaster , thanks for your work on this stub. I just noticed a typo at line 47 where you wrote For the |
Oedipsos
previously approved these changes
Jul 12, 2020
MegaApplePi
reviewed
Jul 28, 2020
|
|
||
| ## Definitions | ||
|
|
||
| Due to the broad nature of the term "tech map," there are many different aspects that could describe the term. The lists below describe different definitions from popular "types" of players. |
There was a problem hiding this comment.
Suggested change
| Due to the broad nature of the term "tech map," there are many different aspects that could describe the term. The lists below describe different definitions from popular "types" of players. | |
| Due to the broad nature of the term "tech map", there are many different aspects that could describe the term. The lists below describe different definitions from popular "types" of players. |
I'd leave the comma outside the quotation.
There was a problem hiding this comment.
The rest of the article uses American English punctuation, which places commas inside quotation marks.
Co-authored-by: Eric <eric@m9pi.net>
MegaApplePi
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a stub for the term "Tech map" ala #3143 and #3151.
This stub covers the use of a hotly debated term; if you have an opposing view to the description listed in this article, please leave a comment and explain your reasoning
To-Do:
Credits to @Nivalyx and K4L1 for helping out with the description
K4L1 gathered all the images (and then some) for me as well, so kudos to you man
Just realized that this pr attracted the attention of a well-known mapper lol