Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyteck Bug Fixes #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

vayner-s
Copy link

@vayner-s vayner-s commented Jul 6, 2021

  1. When looking for the 'target species' for ignition detection, the species key is now used to translate between the name of the species requested by the experimental data and the name used in the model. This is to resolve an issue where pyteck could not find the requested species and was falling back to pressure.

  2. Instead of using the first time in the list of ignition delays returned from get_ignition_delay, the last time is now used since this seems to be the 'max' peak for each of the ignition types based on the way that the ignition delays list is populated. This is to resolve an issue where pyteck was always taking the earliest peak rather than the max peak for specific ignition types.

@vayner-s
Copy link
Author

vayner-s commented Jul 6, 2021

This is relevant for issue #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant