Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (ported) nmaster-ncol.c #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielFabian
Copy link

This is a port from the DWM website. I use a 55" 4k screen and nmaster is really useful in that scenario.

Copy link
Owner

@prabirshrestha prabirshrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to compile with variable being undefined. It would be good to include the file in "config.h.in" with rest of the algorithms.

if(initnm)
return;
for(i = 0; i < MaxMon; i++)
nmasters[i] = nmaster;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/nmaster-ncol.c:12:17: error: use of undeclared identifier 'nmaster'; did you mean
      'nmasters'?
                nmasters[i] = nmaster;
                              ^~~~~~~
                              nmasters

@prabirshrestha
Copy link
Owner

Might be worth adding comments in README or above the file in nmaster-ncol.c about section on dealing with large monitors since this does require a bit more config beside just setting up the layout.

@goyalyashpal
Copy link

@DanielFabian @prabirshrestha ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants