Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the new Neovim health API #1567

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

DestyNova
Copy link
Contributor

@DestyNova DestyNova commented Jul 15, 2024

The old report_(start|ok|info|warn|error) functions are deprecated and break :checkhealth in recent versions of neovim:

Error executing lua: function health#lsp#check, line 1: Vim(call):E117: Unknown function: health#report_start
stack traceback:                                                                                                                                                                             
        [C]: in function 'call'                                                                                                                                                              
        /usr/share/nvim/runtime/lua/vim/health.lua:366: in function '_check'                                                                                                                 
        [string "<nvim>"]:1: in main chunk                        

This PR updates to the new vim.health API and fixes the issue, although I guess it will break checkhealth for very old versions.

…tions are deprecated and break :checkhealth in recent versions of neovim
@prabirshrestha prabirshrestha merged commit f160fe2 into prabirshrestha:master Jul 20, 2024
18 checks passed
@prabirshrestha
Copy link
Owner

Merged. Thanks!

@DestyNova DestyNova deleted the use-new-health-api branch July 20, 2024 05:42
@prabirshrestha
Copy link
Owner

Well this doesn't work as it seems to break vim. #1562 works for both vim and nevoid.

@prabirshrestha
Copy link
Owner

This is now fixed in both vim and neovim.

@DestyNova
Copy link
Contributor Author

Ah, bummer 😮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants