Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the feature of "Scroll to top" button #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Pratik2026
Copy link

Related to #103

I have added the feature of a scroll-to-top button to enhance the user experience. This feature allows users to easily navigate back to the top of the page with a single click.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.

Please refer to the attached video(in full Screen) to view the newly added feature in action.

After.mp4

@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for arito ready!

Name Link
🔨 Latest commit 7ace736
🔍 Latest deploy log https://app.netlify.com/sites/arito/deploys/646b3efea8b1490008243464
😎 Deploy Preview https://deploy-preview-118--arito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your First Pull Request! Wish you best on your open-source journey 😊

@prakhartiwari0
Copy link
Owner

Very good changes @Pratik2026!
I have found a few issues and recommendations,

Problem Solution
image As you can see in this image, due to the colour of this button it's not visible well.

Solutions

  • I would recommend a theme-green colour background, a black border and a black arrow to make it easy to spot.
  • I think maybe the top-right position would be better for this button, or maybe not, we can discuss about this point more.

@Pratik2026 Please make the desired changes and then we will proceed further

Happy Contributing!

Copy link
Owner

@prakhartiwari0 prakhartiwari0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the desired changes I asked in the comments

@Pratik2026
Copy link
Author

@prakhartiwari0 I have made the changes as per your recommendations. Let me know if any further adjustments are needed.

@Pratik2026
Copy link
Author

@prakhartiwari0 Also, regarding the positioning of the Back to Top button. After considering the overall design and user experience, I believe that the current bottom-right position is more suitable. Placing the button at the bottom-right corner aligns with common web design practices, where users expect to find such navigation elements, allowing for easy access to the Back to Top button.

If you have any alternative ideas regarding the button's positioning, I would be happy to discuss them further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants