Skip to content

Commit

Permalink
Find/replace overlay: store search in history when leaving overlay ec…
Browse files Browse the repository at this point in the history
…lipse-platform#2291

The find/replace overlay only stores a search input in the history when
an explicit search operation (forward/backward/all search) is performed.
In case only an incremental search (via search-as-you-type) is
performed, this input will not be added to the history. In some cases,
no explicit search is executed but the final result of a
search-as-you-type input is sufficient for the user. Since this final
result, after they finished typing, also represented a relevant search
input, it should be added to the history.

This change addresses the issue by adding a search input to the history
also when the overlay is left, i.e., the focus is moved to somewhere
else, such as the target editor or some other view.

Fixes eclipse-platform#2291
  • Loading branch information
HeikoKlare committed Sep 19, 2024
1 parent fe9d7e2 commit 88b1d36
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ public void shellActivated(ShellEvent e) {
@Override
public void shellDeactivated(ShellEvent e) {
removeSearchScope();
searchBar.storeHistory();
}
};

Expand Down

0 comments on commit 88b1d36

Please sign in to comment.