Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-721] Upgrade Flink 1.17 #722

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

crazyzhou
Copy link
Contributor

Change log description
Upgrade Flink version to 1.17.1 on master branch

Purpose of the change
Fix #721

What the code does
Upgrade flinkVersion to 1.17.1 in gradle.properties
Address the Sink API change FLINK-30755
Address the jacoco issue hazelcast/hazelcast#20945

How to verify it
./gradlew clean build should pass

Signed-off-by: Brian Zhou <b.zhou@dell.com>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1157b7b) 81.12% compared to head (adb30cd) 81.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #722   +/-   ##
=========================================
  Coverage     81.12%   81.12%           
  Complexity      573      573           
=========================================
  Files            62       62           
  Lines          2723     2723           
  Branches        232      232           
=========================================
  Hits           2209     2209           
  Misses          326      326           
  Partials        188      188           
Files Coverage Δ
...pravega/connectors/flink/ReaderCheckpointHook.java 92.18% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyzhou crazyzhou requested a review from fyang86 October 16, 2023 05:39
Copy link
Contributor

@fyang86 fyang86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazyzhou crazyzhou merged commit faca104 into pravega:master Oct 17, 2023
5 checks passed
@crazyzhou crazyzhou deleted the update-flink-1.17 branch October 17, 2023 03:34
Welkin-Y pushed a commit to Welkin-Y/Pravega-flink-connectors that referenced this pull request Oct 30, 2023
Signed-off-by: Brian Zhou <b.zhou@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Flink 1.17
2 participants