refactor: Better utilize suspense in Tutorial #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
force-pushed
the
refactor/tutorial
branch
2 times, most recently
from
afc020f
to
0de5c58
Compare
rschristian
changed the title
rschristian
commented
Jun 27, 2024
Comment on lines
-1
to
-17
| .errorOverlayWrapper { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| bottom: 0; | ||
| right: 0; | ||
| height: 100%; | ||
| display: flex; | ||
| } | ||
|
|
||
| .close { | ||
| position: absolute; | ||
| top: 1rem; | ||
| right: 1rem; | ||
| z-index: 10; | ||
| } | ||
|
|
There was a problem hiding this comment.
Most of these error styles weren't working correctly as they were sitting under the REPL Runner's styles and/or were redundant, so I stripped them out. Errors should continue to look as they have in the REPL & Tutorial.
JoviDeCroock
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last of the vite & preact-iso migration changes, sorry it took so long for me to land.
Better utilizes suspense, so now we can just rely on the router loading state -- no longer is there any loading of the REPL/Code Editor separately post-mount. This also fixes the full unmount of the route when navigating between tutorial steps, structure is now preserved & content is simply swapped out. Feels a lot smoother.
Certainly let me know if any issues are spotted -- I spent a fair bit of time going through different situations manually but this is the most complex page we have by a fair margin, which is why it was left for last.