Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref unmount imperative handle #4625

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

JoviDeCroock
Copy link
Member

Fixes #4624

Copy link

github-actions bot commented Jan 8, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-9.03ms - +1.89ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.04ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.11ms - +0.79ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.28ms - +0.26ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.56ms - +0.68ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.26ms - +0.16ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-1.15ms - +1.35ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +4% (-0.46ms - +0.39ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +4% (-0.01ms - +0.04ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local943.04ms - 951.30ms-unsure 🔍
-1% - +0%
-9.03ms - +1.89ms
preact-main947.18ms - 954.31msunsure 🔍
-0% - +1%
-1.89ms - +9.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.21ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.20ms - 19.21msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.60ms-unsure 🔍
-0% - +0%
-0.04ms - +0.04ms
preact-main16.55ms - 16.61msunsure 🔍
-0% - +0%
-0.04ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.52ms - 1.54ms-unsure 🔍
-1% - +1%
-0.02ms - +0.01ms
preact-main1.52ms - 1.54msunsure 🔍
-1% - +1%
-0.01ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.43ms - 67.62ms-unsure 🔍
-2% - +1%
-1.11ms - +0.79ms
preact-main66.45ms - 67.92msunsure 🔍
-1% - +2%
-0.79ms - +1.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local10.17ms - 10.66ms-unsure 🔍
-4% - +4%
-0.46ms - +0.39ms
preact-main10.11ms - 10.80msunsure 🔍
-4% - +4%
-0.39ms - +0.46ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local19.06ms - 19.48ms-unsure 🔍
-1% - +1%
-0.28ms - +0.26ms
preact-main19.10ms - 19.46msunsure 🔍
-1% - +1%
-0.26ms - +0.28ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.78ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main3.76ms - 3.79msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4266
  • Commit: 3ba0032

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.00ms - 69.85ms-unsure 🔍
-1% - +1%
-0.56ms - +0.68ms
preact-main68.91ms - 69.82msunsure 🔍
-1% - +1%
-0.68ms - +0.56ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.99ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main2.96ms - 2.99msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.26ms - 30.92ms-unsure 🔍
-1% - +1%
-0.45ms - +0.43ms
preact-main30.31ms - 30.89msunsure 🔍
-1% - +1%
-0.43ms - +0.45ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.30ms - 36.50ms-unsure 🔍
-2% - +3%
-0.75ms - +0.97ms
preact-main35.17ms - 36.40msunsure 🔍
-3% - +2%
-0.97ms - +0.75ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.41ms - 26.74ms-unsure 🔍
-2% - +0%
-0.64ms - +0.10ms
preact-main26.51ms - 27.18msunsure 🔍
-0% - +2%
-0.10ms - +0.64ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.32ms - 28.58ms-unsure 🔍
-0% - +6%
-0.11ms - +1.64ms
preact-main26.57ms - 27.80msunsure 🔍
-6% - +0%
-1.64ms - +0.11ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.59ms - 25.78ms-unsure 🔍
-1% - +5%
-0.31ms - +1.34ms
preact-main24.10ms - 25.25msunsure 🔍
-5% - +1%
-1.34ms - +0.31ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.56ms - 22.96ms-unsure 🔍
-1% - +1%
-0.23ms - +0.34ms
preact-main22.50ms - 22.90msunsure 🔍
-1% - +1%
-0.34ms - +0.23ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #4266
  • Commit: 3ba0032

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.94ms - 2.06ms-unsure 🔍
-5% - +4%
-0.10ms - +0.08ms
preact-main1.95ms - 2.08msunsure 🔍
-4% - +5%
-0.08ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.04ms - 34.32ms-unsure 🔍
-1% - +0%
-0.26ms - +0.16ms
preact-main34.06ms - 34.40msunsure 🔍
-0% - +1%
-0.16ms - +0.26ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.29ms-unsure 🔍
-1% - +4%
-0.01ms - +0.04ms
preact-main1.23ms - 1.27msunsure 🔍
-3% - +1%
-0.04ms - +0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.59ms - 34.57ms-unsure 🔍
-3% - +4%
-1.15ms - +1.35ms
preact-main32.72ms - 34.25msunsure 🔍
-4% - +3%
-1.35ms - +1.15ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.91ms - 2.92ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.91ms - 2.93msunsure 🔍
-0% - +1%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Jan 8, 2025

Size Change: +36 B (+0.06%)

Total Size: 62.4 kB

Filename Size Change
hooks/dist/hooks.js 1.54 kB +13 B (+0.85%)
hooks/dist/hooks.module.js 1.57 kB +13 B (+0.83%)
hooks/dist/hooks.umd.js 1.61 kB +10 B (+0.62%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.12 kB
compat/dist/compat.module.js 4.05 kB
compat/dist/compat.umd.js 4.19 kB
debug/dist/debug.js 3.83 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.91 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.7 kB
dist/preact.min.js 4.72 kB
dist/preact.min.module.js 4.72 kB
dist/preact.min.umd.js 4.74 kB
dist/preact.module.js 4.72 kB
dist/preact.umd.js 4.76 kB
jsx-runtime/dist/jsxRuntime.js 978 B
jsx-runtime/dist/jsxRuntime.module.js 952 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.618% (+0.002%) from 99.616%
when pulling 3ba0032 on ref-unmount-imperative-handle
into a1ff5f3 on main.

@JoviDeCroock JoviDeCroock merged commit 1226aae into main Jan 8, 2025
13 checks passed
@JoviDeCroock JoviDeCroock deleted the ref-unmount-imperative-handle branch January 8, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ref cleanup function does not work when used with imperative handle
3 participants