bump peerDeps for vite 5 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
approved these changes
Nov 17, 2023
|
@rschristian I did get a very odd warning when upgrading which seemed related to our other older deps so no issue doing the downgrade 😅 |
|
First warning I encounter when trying it out
EDIT: seems unrelated to us 🙌 so I think we're good on this |
|
Looks like they might've also missed some Rollup type defs when inlining them in the newest version, so that failed our CI too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on Prefresh already, I have yet to fully test it with this project. I figured that creating the PR is already good to find typing issues.
Resolves #89