Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add demo tsconfig.json, prettifies .json on commit, add preact as a devDep #92

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

rschristian
Copy link
Member

  • Adds tsconfig.json to demo/
    • As we don't set (and can't, due to using tsc as the compilation method) the JSX config, TS will (correctly) trip up if you open the demo in an editor.
  • Adds preact as a devDep
    • Was just testing Vite 5 and had to use --legacy-peer-deps as I didn't want to fiddle with versions, but unfortunately Preact was only implicitly included because it's a peer dep. Should probably be a full dev dep.
  • Prettifies .json on commit else my badly formatted changes to the package.json slip through :p

@rschristian rschristian merged commit 9dce9e9 into main Nov 19, 2023
1 check passed
@rschristian rschristian deleted the misc/housekeeping branch November 19, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants