Avoid isIdentifier() crash on null/undefined values (#778)

* Avoid isIdentifier() crash on null/undefined values * Create gold-candles-sing.md Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
preactjs · Jul 24, 2021 · fd94818 · fd94818
1 parent a1d5f7e
commit fd94818
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/gold-candles-sing.md b/.changeset/gold-candles-sing.md
@@ -0,0 +1,5 @@
+---
+"wmr": patch
+---
+
+Avoid isIdentifier() crash on null/undefined values
diff --git a/packages/wmr/src/lib/acorn-traverse.js b/packages/wmr/src/lib/acorn-traverse.js
@@ -862,7 +862,7 @@ const TYPES = {
 	/** @type {(a:Node,b?:Node)=>boolean} */
 	isIdentifier(a, b) {
 		if (a instanceof Path) a = a.node;
-		if (a.type !== 'Identifier') return false;
+		if (!a || a.type !== 'Identifier') return false;
 		return !b || TYPES.isNodesEquivalent(a, b);
 	},
 	react: {