Brainx adapter: initial commit #12413
Conversation
modules/brainxBidAdapter.js
Outdated
| data.user = { | ||
| buyeruid: generateUUID() | ||
| } | ||
| data.device.ip = navigator.ip || '202.100.48.46'; |
There was a problem hiding this comment.
what is this fallback lol :)
| // console.log('bidRequests-==========', bidRequests); | ||
| // console.log('bidderRequest-==========', bidderRequest); | ||
| data.user = { | ||
| buyeruid: generateUUID() |
There was a problem hiding this comment.
this is odd, it will change every request
|
Our current processing is temporary, and the main purpose is to determine
what problems there are during the review process. Regarding the fixed
writing method, we are already adjusting it~
…On Wed, Nov 6, 2024 at 3:45 AM Patrick McCann ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In modules/brainxBidAdapter.js
<#12413 (comment)>:
> + }
+
+ if (!(bid.params.pubId)) {
+ logWarn('Invalid bid request - missing required field pubId');
+ return false;
+ }
+ return true;
+ },
+ buildRequests(bidRequests, bidderRequest) {
+ const data = converter.toORTB({ bidRequests, bidderRequest })
+ const device = config.getConfig('device') || {};
+ // console.log('data-==========', data);
+ // console.log('bidRequests-==========', bidRequests);
+ // console.log('bidderRequest-==========', bidderRequest);
+ data.user = {
+ buyeruid: generateUUID()
this is odd, it will change every request
—
Reply to this email directly, view it on GitHub
<#12413 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMSAGRP6HWMJWANEFHZS73LZ7EN33AVCNFSM6AAAAABRF4SNH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJWGU2DOMJUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
modules/brainxBidAdapter.js
Outdated
| } | ||
| return { | ||
| method: METHOD, | ||
| url: `${String(deepAccess(bidRequests[0], 'params.endpoint'))}?token=${String(deepAccess(bidRequests[0], 'params.pubId'))}`, |
There was a problem hiding this comment.
endpoint cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.
It may be an optional parameter, but a default is required.
You may also ask the publisher to
pbjs.setConfig({
"brainx": {
"endpoint": "URL"
}
});
At least this is not then replicated thousands of times for each adunit.
There was a problem hiding this comment.
OK, thank you for your reply. We will continue to make adjustments
There was a problem hiding this comment.
Hello, bretg, we have made adjustments to the above issues. Please review it again.
|
docs PR prebid/prebid.github.io#5689 |
Hi bretg, I was wondering when the next merge code will be released? |
|
@ChrisHuie - please assign this to someone for proper review. @Hugh0222 - sorry, we do not have a committed service-level agreement on how long it takes a pull request to get through review. It depends on the complexity and quality of the code as well as the availability of qualified reviewers. |
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information