Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve IGS name #4073

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions openrtb_ext/bidders.go
Original file line number Diff line number Diff line change
Expand Up @@ -276,22 +276,22 @@
BidderReservedPrebid BidderName = "prebid" // Reserved for Prebid Server configuration.
BidderReservedSKAdN BidderName = "skadn" // Reserved for Apple's SKAdNetwork OpenRTB extension.
BidderReservedTID BidderName = "tid" // Reserved for Per-Impression Transactions IDs for Multi-Impression Bid Requests.
BidderReservedAE BidderName = "ae" // Reserved for FLEDGE Auction Environment
)
patmmccann marked this conversation as resolved.
Show resolved Hide resolved
BidderReservedAE BidderName = "ae" // Reserved for PAAPI Auction Environment.
BidderReservedIGS BidderName = "igs" // Reserved for PAAPI Interest Group Seller object.

// IsBidderNameReserved returns true if the specified name is a case insensitive match for a reserved bidder name.
func IsBidderNameReserved(name string) bool {

Check failure on line 283 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'func'

Check failure on line 283 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'func'

Check failure on line 283 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'func'
if strings.EqualFold(name, string(BidderReservedAll)) {

Check failure on line 284 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'if'

Check failure on line 284 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'if'

Check failure on line 284 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'if'
return true

Check failure on line 285 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'return'

Check failure on line 285 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'return'

Check failure on line 285 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'return'
}

Check failure on line 286 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found '}'

Check failure on line 286 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found '}'

Check failure on line 286 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found '}'

if strings.EqualFold(name, string(BidderReservedContext)) {

Check failure on line 288 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'if'

Check failure on line 288 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'if'

Check failure on line 288 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'if'
return true

Check failure on line 289 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'return'

Check failure on line 289 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'return'

Check failure on line 289 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'return'
}

Check failure on line 290 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found '}'

Check failure on line 290 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found '}'

Check failure on line 290 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found '}'

if strings.EqualFold(name, string(BidderReservedData)) {

Check failure on line 292 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'if'

Check failure on line 292 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'if'

Check failure on line 292 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'if'
return true

Check failure on line 293 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found 'return'

Check failure on line 293 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found 'return'

Check failure on line 293 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found 'return'
}

Check failure on line 294 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate-merge

expected 'IDENT', found '}'

Check failure on line 294 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.21.x, ubuntu-20.04)

expected 'IDENT', found '}'

Check failure on line 294 in openrtb_ext/bidders.go

View workflow job for this annotation

GitHub Actions / validate (1.22.x, ubuntu-20.04)

expected 'IDENT', found '}'

if strings.EqualFold(name, string(BidderReservedGeneral)) {
return true
Expand All @@ -317,10 +317,14 @@
return true
}

if strings.EqualFold(name, string(BidderReservedIGS)) {
return true
}

return false
}

// IsPotentialBidder returns true if the name is not reserved witbin the imp[].ext context
// IsPotentialBidder returns true if the name is not reserved within the imp[].ext context
func IsPotentialBidder(name string) bool {
switch BidderName(name) {
case BidderReservedContext:
Expand All @@ -337,6 +341,8 @@
return false
case BidderReservedAE:
return false
case BidderReservedIGS:
return false
default:
return true
}
Expand Down
Loading