Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force ipv4 for prebuild requests #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

force ipv4 for prebuild requests #194

wants to merge 2 commits into from
+1 −1

Commits on May 28, 2024

  1. force ipv4 for prebuild request due to simple-get request timeout whe… 

    …n encountering broken ipv6 routers

The underlying issue is that when dns resolves to multiple IPs all ips are attempted. ipv6 is tried first, then ipv4. for every ip failure, it will emit a timeout event which simple-get interprets as an error. This may be a bug in either node (since the entire request hasnt timed out, just 1 ip attempt), or a bug in simple-get where it should be more discerning about which request timeout events it should observe. In any case, this is an issue with a end user machines ipv6 network configuration. Requiring binaries be hosted on a ipv4 network seems reasonable.
    @koush
    koush committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0b11b82 View commit details
    Browse the repository at this point in the history

  2. Update package.json

    @koush
    koush committed May 28, 2024
    Configuration menu
    Copy the full SHA
    818ad1e View commit details
    Browse the repository at this point in the history