Fix linkage issues

prestodb · Aug 7, 2024 · 32aa4e4 · 32aa4e4
1 parent 00748c2
commit 32aa4e4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/presto-native-execution/presto_cpp/main/connectors/tpcds/CMakeLists.txt b/presto-native-execution/presto_cpp/main/connectors/tpcds/CMakeLists.txt
@@ -31,18 +31,19 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
   add_compile_options(-Wno-stringop-overflow -Wno-write-strings)
 endif()
 
+# Include directories
 include_directories(dsdgen/include)
 include_directories(dsdgen/include/dsdgen-c)
 include_directories(include)
 include_directories(..)
 
+# Add subdirectories
 add_subdirectory(dsdgen/dsdgen-c)
 
-target_link_libraries(dsdgen_c velox_vector_test_lib Folly::folly xsimd)
-
-add_library(dsdgen STATIC include/append_info-c.cpp)
-target_link_libraries(dsdgen dsdgen_c)
+add_library(append_info OBJECT include/append_info-c.cpp)
+target_link_libraries(append_info velox_vector_test_lib Folly::folly xsimd)
+target_link_libraries(dsdgen_c append_info)
 
 add_library(tpcds_gen TpcdsGen.cpp DSDGenIterator.cpp)
 target_include_directories(tpcds_gen PUBLIC dsdgen/include)
-target_link_libraries(tpcds_gen velox_memory velox_vector dsdgen fmt::fmt)
+target_link_libraries(tpcds_gen velox_memory velox_vector dsdgen_c append_info fmt::fmt)
diff --git a/presto-native-execution/presto_cpp/main/connectors/tpcds/dsdgen/dsdgen-c/CMakeLists.txt b/presto-native-execution/presto_cpp/main/connectors/tpcds/dsdgen/dsdgen-c/CMakeLists.txt
@@ -13,7 +13,7 @@
 # limitations under the License.
 
 add_library(
-  dsdgen_c STATIC
+  dsdgen_c OBJECT
   skip_days.cpp
   address.cpp
   build_support.cpp