Addressed comments by Anant

prestodb · Nov 20, 2024 · 40b6f47 · 40b6f47
1 parent 95d4186
commit 40b6f47
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/presto-main/src/main/java/com/facebook/presto/cost/ScalarStatsCalculator.java b/presto-main/src/main/java/com/facebook/presto/cost/ScalarStatsCalculator.java
@@ -117,14 +117,14 @@ private class RowExpressionStatsVisitor
         private final PlanNodeStatsEstimate input;
         private final ConnectorSession session;
         private final FunctionResolution resolution = new FunctionResolution(metadata.getFunctionAndTypeManager().getFunctionAndTypeResolver());
-        private final boolean isStatsPropagationEnabled;
+        private final boolean isScalarFunctionStatsPropagationEnabled;
 
         public RowExpressionStatsVisitor(PlanNodeStatsEstimate input, ConnectorSession session)
         {
             this.input = requireNonNull(input, "input is null");
             this.session = requireNonNull(session, "session is null");
             // casting session to FullConnectorSession is not ideal.
-            this.isStatsPropagationEnabled =
+            this.isScalarFunctionStatsPropagationEnabled =
                     SystemSessionProperties.shouldEnableScalarFunctionStatsPropagation(((FullConnectorSession) session).getSession());
         }
 
@@ -216,7 +216,7 @@ public VariableStatsEstimate visitSpecialForm(SpecialFormExpression specialForm,
 
         private VariableStatsEstimate computeStatsViaAnnotations(CallExpression call, Void context, FunctionMetadata functionMetadata)
         {
-            if (isStatsPropagationEnabled) {
+            if (isScalarFunctionStatsPropagationEnabled) {
                 if (functionMetadata.hasStatsHeader() && call.getFunctionHandle() instanceof BuiltInFunctionHandle) {
                     Signature signature = ((BuiltInFunctionHandle) call.getFunctionHandle()).getSignature().canonicalization();
                     Optional<ScalarStatsHeader> statsHeader = functionMetadata.getScalarStatsHeader(signature);

diff --git a/presto-main/src/test/java/com/facebook/presto/cost/TestScalarStatsCalculator.java b/presto-main/src/test/java/com/facebook/presto/cost/TestScalarStatsCalculator.java
@@ -917,6 +917,7 @@ public static long customPrng(
             return (long) ((Math.random() * (max - min)) + min);
         }
 
+        // Following functions are annotated with incorrect Stats annotation to cover -ve or boundary conditions.
         @ScalarFunction(value = "custom_is_null2", calledOnNullInput = true)
         @SqlType(StandardTypes.BOOLEAN)
         @ScalarFunctionConstantStats(distinctValuesCount = -3.19, nullFraction = 0.0)