Deprecate regex property for tracing

prestodb · Dec 20, 2024 · 737f5e1 · 737f5e1
1 parent 0720f17
commit 737f5e1
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 27 deletions.
diff --git a/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst b/presto-docs/src/main/sphinx/presto_cpp/properties-session.rst
@@ -378,15 +378,6 @@ The fragment id to be traced. If not specified, all fragments will be matched.
 
 The shard id to be traced. If not specified, all shards will be matched.
 
-``native_query_trace_task_reg_exp``
-^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-* **Type:** ``varchar``
-* **Default value:** ``""``
-
-The regular expression to match a task for tracing. It will be deprecated if there is
-no issue with native_query_trace_fragment_id and native_query_trace_shard_id.
-
 ``native_scaled_writer_rebalance_max_memory_usage_ratio``
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 

diff --git a/...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java b/...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
@@ -62,7 +62,6 @@ public class NativeWorkerSessionPropertyProvider
     public static final String NATIVE_QUERY_TRACE_DIR = "native_query_trace_dir";
     public static final String NATIVE_QUERY_TRACE_NODE_IDS = "native_query_trace_node_ids";
     public static final String NATIVE_QUERY_TRACE_MAX_BYTES = "native_query_trace_max_bytes";
-    public static final String NATIVE_QUERY_TRACE_REG_EXP = "native_query_trace_task_reg_exp";
     public static final String NATIVE_QUERY_TRACE_FRAGMENT_ID = "native_query_trace_fragment_id";
     public static final String NATIVE_QUERY_TRACE_SHARD_ID = "native_query_trace_shard_id";
     public static final String NATIVE_MAX_LOCAL_EXCHANGE_PARTITION_COUNT = "native_max_local_exchange_partition_count";
@@ -237,10 +236,6 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
                         "The max trace bytes limit. Tracing is disabled if zero.",
                         0L,
                         !nativeExecution),
-                stringProperty(NATIVE_QUERY_TRACE_REG_EXP,
-                        "The regexp of traced task id. We only enable trace on a task if its id matches.",
-                        "",
-                        !nativeExecution),
                 stringProperty(NATIVE_OP_TRACE_DIR_CREATE_CONFIG,
                         "Config used to create operator trace directory. This config is provided to underlying file system and the config is free form. The form should be defined by the underlying file system.",
                         "",

diff --git a/presto-native-execution/presto_cpp/main/SessionProperties.cpp b/presto-native-execution/presto_cpp/main/SessionProperties.cpp
@@ -306,14 +306,6 @@ SessionProperties::SessionProperties() {
       QueryConfig::kQueryTraceMaxBytes,
       std::to_string(c.queryTraceMaxBytes()));
 
-  addSessionProperty(
-      kQueryTraceTaskRegExp,
-      "The regexp of traced task id. We only enable trace on a task if its id"
-      " matches.",
-      VARCHAR(),
-      false,
-      QueryConfig::kQueryTraceTaskRegExp,
-      c.queryTraceTaskRegExp());
 
   addSessionProperty(
       kOpTraceDirectoryCreateConfig,

diff --git a/presto-native-execution/presto_cpp/main/SessionProperties.h b/presto-native-execution/presto_cpp/main/SessionProperties.h
@@ -232,11 +232,6 @@ class SessionProperties {
   static constexpr const char* kQueryTraceMaxBytes =
       "native_query_trace_max_bytes";
 
-  /// The regexp of traced task id. We only enable trace on a task if its id
-  /// matches.
-  static constexpr const char* kQueryTraceTaskRegExp =
-      "native_query_trace_task_reg_exp";
-
   /// Config used to create operator trace directory. This config is provided to
   /// underlying file system and the config is free form. The form should be
   /// defined by the underlying file system.