Skip to content

Commit

Permalink
Remove old tests with PlanValidateRequest no longer used
Browse files Browse the repository at this point in the history
  • Loading branch information
BryanCutler committed Sep 12, 2024
1 parent b5468e9 commit d5941a7
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 343 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -248,21 +248,3 @@ TEST_F(PlanConverterTest, batchPlanConversion) {
std::dynamic_pointer_cast<const operators::ShuffleReadNode>(curNode);
ASSERT_NE(shuffleReadNode, nullptr);
}

TEST_F(PlanConverterTest, TestPlanValidateRequestConversion) {
std::string str = slurp(getDataPath("PlanValidateRequest.json"));
json j = json::parse(str);
protocol::PlanValidateRequest p = j;
ASSERT_EQ(p.planNode->_type, ".AggregationNode");

// Check plan node conversion
auto queryCtx = std::make_shared<core::QueryCtx>();
auto pool = memory::deprecatedAddDefaultLeafMemoryPool();
VeloxInteractiveQueryPlanConverter converter(queryCtx.get(), pool.get());

core::PlanNodePtr planConv = converter.toVeloxQueryPlan(p.planNode, nullptr, "20201107_130540_00011_wrpkw.1.2.3");
ASSERT_EQ(planConv->id(), "2");

auto aggregationNode = std::dynamic_pointer_cast<const core::AggregationNode>(planConv);
ASSERT_NE(aggregationNode, nullptr);
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ add_executable(
TypeErrorTest.cpp
VariableReferenceExpressionTest.cpp
PlanFragmentTest.cpp
PlanValidateRequestTest.cpp)
)
add_test(
NAME presto_protocol_test
COMMAND presto_protocol_test
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit d5941a7

Please sign in to comment.