[native] Add JWT processing when using http(s) comms #20290

czentgr · 2023-07-12T14:05:32Z

Adding creation and verification of a JWT signed using HMAC SHA-256.
The JWT is used for authentication of internal communication.
On the Java side PR #19706 added authentication for internal
communication using a JWT token signed with HMAC SHA-256.

Adding this comment enables Prestissimo to to be configured
to verify internal communication requests, e.g from a Java
coordinator.

New system configuration options:

internal-communication.jwt.enabled=[true/false]
internal-communication.shared-secret=<shared-secret-value>
internal-communication.jwt.expiration-seconds=<value in seconds>

A new external dependency jet-cpp from the https://github.com/Thalhammer/jwt-cpp
repo is added to a new setup-adapter.sh script for Prestissimo.
In the dependency directory run
"/scripts/setup-adapter.sh jwt" to install it
The jwt-cpp project handles the creation/parsing/verification of the JWT.

A new build options are added to the build environment:
PRESTO_ENABLE_JWT - default off, if on adds jet creation and verification capability,
turned on during the pipeline build.

Test plan - (Please fill in how you tested your changes)

The PR adds a number of unit tests to the gtest HttpTest suite:

good case
case when JWT is expired
case when the shared secret doesn't match
case when the server secret was unset

Resolves issue #19861.

== RELEASE NOTES ==

Prestissimo (Native Execution) Changes
* Add support for internal authentication using JWT. It can be configured using configs "internal-communication.jwt.enabled=[true/false]", 
  "internal-communication.shared-secret=<shared-secret-value>" and "internal-communication.jwt.expiration-seconds=<value in seconds>"

czentgr · 2023-07-12T22:35:59Z

TODOs left

cleanup more of the unit tests and add more tests (client sends no JWT but server requires one)
add E2E test with Java coordinator and prestissimo worker being configured to use JWT - all native E2E tests run with JWT
Resolve questions:
Replace jwt-cpp base.h with folly::base64 encode/decode implementation? - Yes.
Log rejected requests to the log needed? - No. Enabling the access log already shows the request result. If rejected 401 is shown. Similar to this example

I20230715 00:11:19.770259 1057195 AccessLogFilter.cpp:69] 127.0.0.1 - - [2023-07-15 00:11:19] "GET /v1/info/state HTTP/1.1" 401 8   0

czentgr · 2023-07-12T22:54:36Z

Test results from running HttpTest gtest.

czentgr@Christians-MacBook-Pro tests % ./presto_http_test                          
[==========] Running 21 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from HttpsBasicTest
[ RUN      ] HttpsBasicTest.ssl
[       OK ] HttpsBasicTest.ssl (28 ms)
[----------] 1 test from HttpsBasicTest (28 ms total)

[----------] 20 tests from HTTPTest/HttpTestSuite
[ RUN      ] HTTPTest/HttpTestSuite.basic/0
[       OK ] HTTPTest/HttpTestSuite.basic/0 (1037 ms)
[ RUN      ] HTTPTest/HttpTestSuite.basic/1
[       OK ] HTTPTest/HttpTestSuite.basic/1 (1030 ms)
[ RUN      ] HTTPTest/HttpTestSuite.httpResponseAllocationFailure/0
E20230714 19:28:20.953740 916573 Exceptions.h:68] Line: /Users/czentgr/gitspace/presto/presto-native-execution/velox/velox/common/memory/MemoryPool.cpp:734, Function:incrementReservationThreadSafe, Expression:  
Exceeded memory pool cap of 1.00KB with max 1.00KB when requesting 1.00MB, memory manager cap is UNLIMITED
default_root_0 usage 0B peak 0B

Failed memory pool: httpResponseAllocationFailure: 0B
, Source: RUNTIME, ErrorCode: MEM_CAP_EXCEEDED
E20230714 19:28:20.955370 916495 Exceptions.h:68] Line: /Users/czentgr/gitspace/presto/presto-native-execution/./presto_cpp/main/http/HttpClient.h:75, Function:consumeBody, Expression: !hasError() , Source: RUNTIME, ErrorCode: INVALID_STATE
[       OK ] HTTPTest/HttpTestSuite.httpResponseAllocationFailure/0 (22 ms)
[ RUN      ] HTTPTest/HttpTestSuite.httpResponseAllocationFailure/1
E20230714 19:28:20.960577 916585 Exceptions.h:68] Line: /Users/czentgr/gitspace/presto/presto-native-execution/velox/velox/common/memory/MemoryPool.cpp:734, Function:incrementReservationThreadSafe, Expression:  
Exceeded memory pool cap of 1.00KB with max 1.00KB when requesting 1.00MB, memory manager cap is UNLIMITED
default_root_1 usage 0B peak 0B

Failed memory pool: httpResponseAllocationFailure: 0B
, Source: RUNTIME, ErrorCode: MEM_CAP_EXCEEDED
E20230714 19:28:20.960752 916495 Exceptions.h:68] Line: /Users/czentgr/gitspace/presto/presto-native-execution/./presto_cpp/main/http/HttpClient.h:75, Function:consumeBody, Expression: !hasError() , Source: RUNTIME, ErrorCode: INVALID_STATE
[       OK ] HTTPTest/HttpTestSuite.httpResponseAllocationFailure/1 (4 ms)
[ RUN      ] HTTPTest/HttpTestSuite.serverRestart/0
[       OK ] HTTPTest/HttpTestSuite.serverRestart/0 (17 ms)
[ RUN      ] HTTPTest/HttpTestSuite.serverRestart/1
[       OK ] HTTPTest/HttpTestSuite.serverRestart/1 (5 ms)
[ RUN      ] HTTPTest/HttpTestSuite.basicJwtTest/0
[       OK ] HTTPTest/HttpTestSuite.basicJwtTest/0 (8 ms)
[ RUN      ] HTTPTest/HttpTestSuite.basicJwtTest/1
[       OK ] HTTPTest/HttpTestSuite.basicJwtTest/1 (2 ms)
[ RUN      ] HTTPTest/HttpTestSuite.asyncRequests/0
[       OK ] HTTPTest/HttpTestSuite.asyncRequests/0 (8 ms)
[ RUN      ] HTTPTest/HttpTestSuite.asyncRequests/1
[       OK ] HTTPTest/HttpTestSuite.asyncRequests/1 (3 ms)
[ RUN      ] HTTPTest/HttpTestSuite.timedOutRequests/0
[       OK ] HTTPTest/HttpTestSuite.timedOutRequests/0 (109 ms)
[ RUN      ] HTTPTest/HttpTestSuite.timedOutRequests/1
[       OK ] HTTPTest/HttpTestSuite.timedOutRequests/1 (107 ms)
[ DISABLED ] HTTPTest/HttpTestSuite.DISABLED_outstandingRequests/0
[ DISABLED ] HTTPTest/HttpTestSuite.DISABLED_outstandingRequests/1
[ RUN      ] HTTPTest/HttpTestSuite.testReportOnBodyStatsFunc/0
[       OK ] HTTPTest/HttpTestSuite.testReportOnBodyStatsFunc/0 (13 ms)
[ RUN      ] HTTPTest/HttpTestSuite.testReportOnBodyStatsFunc/1
[       OK ] HTTPTest/HttpTestSuite.testReportOnBodyStatsFunc/1 (3 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtSecretMismatch/0
[       OK ] HTTPTest/HttpTestSuite.jwtSecretMismatch/0 (1005 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtSecretMismatch/1
[       OK ] HTTPTest/HttpTestSuite.jwtSecretMismatch/1 (1012 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtExpiredToken/0
[       OK ] HTTPTest/HttpTestSuite.jwtExpiredToken/0 (1525 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtExpiredToken/1
[       OK ] HTTPTest/HttpTestSuite.jwtExpiredToken/1 (1516 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtServerVerificationDisabled/0
[       OK ] HTTPTest/HttpTestSuite.jwtServerVerificationDisabled/0 (526 ms)
[ RUN      ] HTTPTest/HttpTestSuite.jwtServerVerificationDisabled/1
[       OK ] HTTPTest/HttpTestSuite.jwtServerVerificationDisabled/1 (511 ms)
[----------] 20 tests from HTTPTest/HttpTestSuite (8473 ms total)

[----------] Global test environment tear-down
[==========] 21 tests from 2 test suites ran. (8502 ms total)
[  PASSED  ] 21 tests.

  YOU HAVE 2 DISABLED TESTS

czentgr · 2023-07-17T16:35:08Z

@aditi-pandit @majetideepak Please take a look when you get a chance.

aditi-pandit

Had a quick read and have some very high level comments.

...e-execution/src/test/java/com/facebook/presto/nativeworker/PrestoNativeQueryRunnerUtils.java

presto-native-execution/presto_cpp/external/jwt-cpp/traits/nlohmann-json/traits.h

presto-native-execution/presto_cpp/external/jwt-cpp/traits/nlohmann-json/defaults.h

aditi-pandit · 2023-07-18T02:38:29Z

presto-native-execution/presto_cpp/main/http/filters/JwtTokenFilter.cpp

+
+// If the internal communication is not enabled the filter
+// is not added to process incoming requests.
+void JWTTokenFilter::onRequest(


Would you need to add any runtime counters in this logic ?

Counter to count number of bad requests?
Not sure exactly what you mean. The Java code didn't seem to add counters so I didn't consider it.

presto-native-execution/presto_cpp/main/http/filters/JwtTokenFilter.cpp

presto-native-execution/presto_cpp/main/http/filters/CMakeLists.txt

czentgr · 2023-07-25T14:45:00Z

The test appears to have run into a connection issue with hive when testing insertion into partitioned tables.

2023-07-24T23:12:50.4633983Z io.prestodb.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20230724_231248_00401_pw3cx): File /tmp/presto-hdfs/8db65272-cdfc-4e00-a2dd-6dc8cbda05a4/returnflag=A/20230724_231248_00401_pw3cx_85c9bd23-df28-4e6e-985d-a6b489f8aa3d could only be replicated to 0 nodes instead of minReplication (=1).  There are 1 datanode(s) running and no node(s) are excluded in this operation.

Two tests failed as a result.
These failures are not related to my changes.

majetideepak · 2023-07-26T16:29:20Z

@czentgr I looked at the https://github.com/Thalhammer/jwt-cpp repo and it looks like there are still some changes being merged. How often do we have to update this code?
Can we make that an external dependency instead of checking in the code?
Also, any reason to pin 0.6.0?

majetideepak · 2023-07-26T16:31:21Z

Do we know the overhead of JWT?

czentgr · 2023-07-26T17:12:55Z

Do we know the overhead of JWT?

No, probably would need to add benchmark tests to compare. Overhead is JSON parsing and generating the HS256 signature of the header/payload. It would think it is more or less negligible. The token are not that large and I assume the openssl implementation for the hashing is efficient.

czentgr · 2023-07-26T17:29:52Z

@czentgr I looked at the https://github.com/Thalhammer/jwt-cpp repo and it looks like there are still some changes being merged. How often do we have to update this code? Can we make that an external dependency instead of checking in the code? Also, any reason to pin 0.6.0?

0.6.0 was the last release. The current one is (was) in release candidate stage (and has been for a while). Perhaps it updated now since I last checked.

I was thinking of adding it to the setup scripts (and had ti running like that) but then saw the json module was also added as code.

Edit: something like Velox does but using CMake to access github and build/install I guess would work. I tried to use that module in the prestissimo CMake and there were some issues with the macros (certain variables related to Velox need to be set).

czentgr · 2023-07-26T22:18:21Z

As discussed with @majetideepak

move the jwt dependency into the setup scripts and remove from the source code
keep base64 implementation of jwt-cpp (aka no changes to the project)
see how the nlohman-json can be used withiin the jwt-cpp project. It uses the nlohman-json name for the header inclusion while the actual nlohman-json source code was copied as a header and renamed in the externals folder to simply json.h
add CMake option (and define) to exclude building the additional code for the usage and verification - by default it is enabled but can be disabled - do some refactoring to make this easy
write small benchmark (with the existing benchmark tooling) to see how much overheard adding jwt usage on client and server entails

czentgr · 2023-08-18T15:49:23Z

Trying to re-use the nlogman jsopn file is not possible. The jwt-cpp will look for

/usr/local/include/jwt-cpp/traits/nlohmann-json/traits.h:5:10: fatal error: 'nlohmann/json.hpp' file not found
#include "nlohmann/json.hpp"

the file in the system path. Without changing the code it is not possible to use the already included file that resides in external/json/json.hpp.

I guess there is a larger discussion on reuse of components and how they are accessed. Perhaps the nlohmann/json should also be a dependency. Dependencies could be installed via the setup scripts or the cmake files (that download and build the project).

czentgr · 2023-08-21T15:02:40Z

I wrote a small benchmark and the results show that the difference is negligible (10,000 requests). I ran multiple times in my local environment. The time seemed to vary occasionally quite a bit. Here are example outputs:

czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       15.95s    62.68m
jwt                                             98.187%     16.25s    61.54m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       16.23s    61.63m
jwt                                             98.678%     16.44s    60.81m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       15.82s    63.20m
jwt                                             98.752%     16.02s    62.41m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       16.03s    62.37m
jwt                                             98.969%     16.20s    61.73m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       15.81s    63.25m
jwt                                             94.488%     16.73s    59.77m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       21.30s    46.94m
jwt                                             112.02%     19.02s    52.59m
WARNING: Benchmark running in DEBUG mode
czentgr@Christians-MacBook-Pro presto-native-execution % _build/release/presto_cpp/main/http/tests/presto_http_jwt_benchmark
WARNING: Benchmark running in DEBUG mode
============================================================================
[...]n/http/tests/HttpJwtBenchmarkTest.cpp     relative  time/iter   iters/s
============================================================================
nojwt                                                       22.34s    44.76m
jwt                                             97.487%     22.92s    43.64m
WARNING: Benchmark running in DEBUG mode

My environment is probably not the best to test at it is varying too much depending on what else is going on.

majetideepak

@czentgr final set of comments. Looks good overall. Can you also verify on a standalone cluster?

majetideepak · 2023-09-06T15:08:34Z

presto-docs/src/main/sphinx/develop/presto-native.rst

+    * **Type** ``integer``
+    * **Default value:** ``300``
+
+    There is a time period between ceating the JWT on the client


typo: creating

majetideepak · 2023-09-06T15:26:16Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

@@ -161,6 +162,15 @@ void PrestoServer::run() {
            "Https Client Certificates are not configured correctly");
      }
      clientCertAndKeyPath = optionalClientCertPath.value();
+
+      if (systemConfig->internalCommunicationJwtEnabled()) {
+#ifdef PRESTO_JWT_ENABLED


This should be #ifndef?

Yes, you are correct.

majetideepak · 2023-09-06T15:27:22Z

presto-native-execution/presto_cpp/main/http/filters/CMakeLists.txt

+
+if(PRESTO_ENABLE_JWT)
+  target_include_directories(
+    http_filters PUBLIC ${CMAKE_SOURCE_DIR}/presto_cpp/external/json)


Can this be PRIVATE?

It was private but then it needs another line in the upper cmake (for the http client). I tried to avoid that.

majetideepak · 2023-09-06T15:28:11Z

presto-native-execution/presto_cpp/main/http/filters/InternalAuthenticationFilter.cpp

+
+namespace facebook::presto::http::filters {
+
+/// If the internal communication is not enabled the filter


Missing comma after enabled If the internal communication is not enabled,

majetideepak · 2023-09-06T15:28:33Z

presto-native-execution/presto_cpp/main/http/filters/InternalAuthenticationFilter.cpp

+namespace facebook::presto::http::filters {
+
+/// If the internal communication is not enabled the filter
+/// is not added to process incoming requests.


process's

majetideepak · 2023-09-06T15:35:28Z

presto-native-execution/presto_cpp/main/http/tests/HttpJwtTest.cpp

+INSTANTIATE_TEST_CASE_P(
+    HTTPJwtTest,
+    HttpJwtTestSuite,
+    ::testing::Values(true, false));


Add an empty newline at the end.

steveburnett

Two small formatting suggestions for the docs page presto-docs/src/main/sphinx/develop/presto-native.rst.

Also - and there may be a good reason for this - I wanted to ask why this page is not included in the Developer index in presto-docs/src/main/sphinx/develop.rst?

steveburnett · 2023-09-12T20:04:48Z

presto-docs/src/main/sphinx/develop/presto-native.rst

+--------------------------
+
+Prestissimo supports JWT authentication for internal communication.
+For details on the generally supported parameters visit :doc:`JWT</security/internal-communication>`.


Suggested change

For details on the generally supported parameters visit :doc:`JWT</security/internal-communication>`.

For details on the generally supported parameters visit `JWT </security/internal-communication.html#jwt>`_.

Links directly to the JWT section.

Not sure the proposed change generates the desired link (it is changed to an external link). Locally, it creates file:///security/internal-communication.html#jwt which is not correct.

Interesting: I built locally with this proposed change (yesterday, and just now to retest after your comment) and the link works for me, opening the page at the JWT target.

If it doesn't work for you, please ignore this suggestion and I'll look into this later. Thanks for checking!

This works

`JWT <../security/internal-communication.html#jwt>`_.

(relative path needed the .. to switch dirs properly).
I will make that change.

Excellent, and thank you for letting me know what you found as this is useful elsewhere in the docs!

presto-docs/src/main/sphinx/develop/presto-native.rst

czentgr · 2023-09-12T22:23:01Z

Two small formatting suggestions for the docs page presto-docs/src/main/sphinx/develop/presto-native.rst.

Also - and there may be a good reason for this - I wanted to ask why this page is not included in the Developer index in presto-docs/src/main/sphinx/develop.rst?

Thanks you @steveburnett .
I will update. Regarding the pressto-native.rst page - we had a different PR to add the link to the develop pages. See PR #20792.

steveburnett · 2023-09-13T15:15:56Z

Thanks you @steveburnett . I will update. Regarding the pressto-native.rst page - we had a different PR to add the link to the develop pages. See PR #20792.

Thanks! I must not have pulled the latest merges for master when I asked that: the link on develop.rst that I wasn't seeing when I wrote my question is in place now.

czentgr · 2023-09-18T16:38:07Z

@steveburnett would you please re-review the latest changes (based on your comments) and approve, if ok? Not sure if your requested changes block the progression. Thanks!

steveburnett

LGTM! (docs)

steveburnett · 2023-09-18T17:19:25Z

@steveburnett would you please re-review the latest changes (based on your comments) and approve, if ok? Not sure if your requested changes block the progression. Thanks!

I don't think I block anything, honestly, but everything looks great to me now so I'm happy to approve from a docs perspective if it matters! Just did.

majetideepak · 2023-10-03T20:47:45Z

presto-native-execution/presto_cpp/main/http/tests/HttpJwtTest.cpp

+  auto rawSystemConfig =
+      std::make_unique<core::MemConfigMutable>(initalSystemConfig);
+  auto systemConfig = SystemConfig::instance();
+  systemConfig->initialize(std::move(rawSystemConfig));


We should create a helper SystemConfig* jwtSystemConfig(); where we set the correct config. Probably reuse this inside basicJwtTest.
We then only use the changedSystemConfig to change the JWT config.

We should probably have a separate server and client config with override.
See https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/storage_adapters/s3fs/tests/MinioServer.h#L51

majetideepak · 2023-10-03T20:48:11Z

presto-native-execution/presto_cpp/main/http/tests/HttpTestBase.h

+        });
+  };
+}
+} // namespace


new line here

majetideepak

@czentgr looks good overall. Made a couple of comments. I will merge this tomorrow if you can address the comments today.

@amitkdutta Let us know if you have any comments on this.

majetideepak · 2023-10-04T01:29:53Z

presto-native-execution/presto_cpp/main/http/tests/HttpJwtTest.cpp

+        {std::string(NodeConfig::kNodeId), std::string("testnode")}};
+    std::unique_ptr<Config> rawNodeConfig =
+        std::make_unique<core::MemConfig>(nodeConfigValues);
+    nodeConfig_->initialize(std::move(rawNodeConfig));


Don't need the nodeConfig_ class variable.

majetideepak · 2023-10-04T01:30:47Z

presto-native-execution/presto_cpp/main/http/tests/HttpJwtTest.cpp

+    return response;
+  }
+
+  const std::shared_ptr<MemoryPool> memoryPool_ =


This is only used once inside produceHttpResponse. Let's remove this and get the defaultMemoryManager at the call site.

majetideepak · 2023-10-04T01:31:18Z

presto-native-execution/presto_cpp/main/http/tests/HttpJwtTest.cpp

+
+  NodeConfig* nodeConfig_ = NodeConfig::instance();
+
+  const std::unordered_map<std::string, std::string> defaultSystemConfig_{


This can be part of jwtSystemConfig as well.

Adding creation and verification of a JWT signed using HMAC SHA-256. The JWT is used for authentication of internal communication. On the Java side PR prestodb#19706 added authentication for internal communication using a JWT token signed with HMAC SHA-256. Adding this comment enables Prestissimo to to be configured to verify internal communication requests, e.g from a Java coordinator. New system configuration options: - internal-communication.jwt.enabled=[true/false] - internal-communication.shared-secret=<shared-secret-value> - internal-communication.jwt.expiration-seconds=<value in seconds> A new external dependency jet-cpp from the https://github.com/Thalhammer/jwt-cpp repo is added to a new setup-adapter.sh script for Prestissimo. In the dependency directory run "<path to presto-native-execution>/scripts/setup-adapter.sh jwt" to install it The jwt-cpp project handles the creation/parsing/verification of the JWT. A new build options are added to the build environment: PRESTO_ENABLE_JWT - default off, if on adds jet creation and verification capability, turned on during the pipeline build.

majetideepak

Thanks for addressing all the comments @czentgr

majetideepak · 2023-10-04T15:39:33Z

@tdcmeehan Can we get an approval from prestodb/committers? Thanks.

czentgr added the MVP Prestissimo MVP label Jul 12, 2023

czentgr force-pushed the cz_add_jwt_usage branch 5 times, most recently from 324dfc8 to 0871a56 Compare July 17, 2023 14:43

czentgr marked this pull request as ready for review July 17, 2023 16:23

czentgr requested a review from a team as a code owner July 17, 2023 16:23

czentgr changed the title ~~[WIP] [native] Add JWT processing when using http(s) comms~~ [native] Add JWT processing when using http(s) comms Jul 17, 2023

czentgr changed the title ~~[native] Add JWT processing when using http(s) comms~~ [WIP][native] Add JWT processing when using http(s) comms Jul 17, 2023

czentgr force-pushed the cz_add_jwt_usage branch from 0871a56 to c774be5 Compare July 18, 2023 00:15

aditi-pandit reviewed Jul 18, 2023

View reviewed changes

czentgr force-pushed the cz_add_jwt_usage branch from c774be5 to a779518 Compare July 24, 2023 22:36

czentgr changed the title ~~[WIP][native] Add JWT processing when using http(s) comms~~ [native] Add JWT processing when using http(s) comms Jul 24, 2023

czentgr force-pushed the cz_add_jwt_usage branch from a779518 to ed89762 Compare July 25, 2023 20:28

czentgr changed the title ~~[native] Add JWT processing when using http(s) comms~~ [WIP][native] Add JWT processing when using http(s) comms Jul 26, 2023

czentgr force-pushed the cz_add_jwt_usage branch from ed89762 to f24f4c8 Compare August 21, 2023 18:13

czentgr requested a review from a team as a code owner August 21, 2023 18:13

czentgr requested a review from presto-oss August 21, 2023 18:13

majetideepak reviewed Sep 6, 2023

View reviewed changes

majetideepak requested a review from amitkdutta September 6, 2023 15:41

ethanyzhang requested a review from nmahadevuni September 6, 2023 16:08

czentgr force-pushed the cz_add_jwt_usage branch 4 times, most recently from 4c4446d to f37c65e Compare September 11, 2023 16:22

steveburnett requested changes Sep 12, 2023

View reviewed changes

czentgr force-pushed the cz_add_jwt_usage branch from f37c65e to 66c187b Compare September 13, 2023 18:27

steveburnett approved these changes Sep 18, 2023

View reviewed changes

czentgr force-pushed the cz_add_jwt_usage branch from 66c187b to cb8cb16 Compare October 3, 2023 19:47

majetideepak reviewed Oct 3, 2023

View reviewed changes

czentgr force-pushed the cz_add_jwt_usage branch from cb8cb16 to c3b5514 Compare October 4, 2023 00:48

majetideepak reviewed Oct 4, 2023

View reviewed changes

czentgr force-pushed the cz_add_jwt_usage branch from c3b5514 to 21b67a7 Compare October 4, 2023 01:39

majetideepak approved these changes Oct 4, 2023

View reviewed changes

tdcmeehan approved these changes Oct 4, 2023

View reviewed changes

majetideepak merged commit ed5727c into prestodb:master Oct 4, 2023

wanglinsong mentioned this pull request Dec 8, 2023

Add release notes for 0.285 #21500

Closed

26 tasks

czentgr deleted the cz_add_jwt_usage branch July 31, 2024 17:44


		namespace facebook::presto::http::filters {

		/// If the internal communication is not enabled the filter

	For details on the generally supported parameters visit :doc:`JWT</security/internal-communication>`.
	For details on the generally supported parameters visit `JWT </security/internal-communication.html#jwt>`_.


		NodeConfig* nodeConfig_ = NodeConfig::instance();

		const std::unordered_map<std::string, std::string> defaultSystemConfig_{

[native] Add JWT processing when using http(s) comms #20290

[native] Add JWT processing when using http(s) comms #20290

Conversation

czentgr commented Jul 12, 2023 • edited Loading

czentgr commented Jul 12, 2023 • edited Loading

czentgr commented Jul 12, 2023 • edited Loading

czentgr commented Jul 17, 2023

aditi-pandit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czentgr commented Jul 25, 2023

majetideepak commented Jul 26, 2023

majetideepak commented Jul 26, 2023

czentgr commented Jul 26, 2023

czentgr commented Jul 26, 2023 • edited Loading

czentgr commented Jul 26, 2023 • edited Loading

czentgr commented Aug 18, 2023

czentgr commented Aug 21, 2023 • edited Loading

majetideepak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czentgr Sep 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czentgr commented Sep 12, 2023

steveburnett commented Sep 13, 2023

czentgr commented Sep 18, 2023

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett commented Sep 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majetideepak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majetideepak left a comment

Choose a reason for hiding this comment

majetideepak commented Oct 4, 2023

czentgr commented Jul 12, 2023 •

edited

Loading

czentgr commented Jul 12, 2023 •

edited

Loading

czentgr commented Jul 12, 2023 •

edited

Loading

czentgr commented Jul 26, 2023 •

edited

Loading

czentgr commented Jul 26, 2023 •

edited

Loading

czentgr commented Aug 21, 2023 •

edited

Loading

czentgr Sep 6, 2023 •

edited

Loading

steveburnett commented Sep 18, 2023 •

edited

Loading