Arrow-flight connector #23032

sabbasani · 2024-06-19T11:23:38Z

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`
* Add documentation for the :doc:`/connector/base-arrow-flight`  :pr:`23032`

If release note is NOT required, use:

== NO RELEASE NOTE ==

steveburnett · 2024-06-19T14:22:18Z

Consider adding documentation for the new connector.

Suggest revising the release note entry to follow the Release Note Guidelines:

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`

tdcmeehan

It seems like there's a hardcoded presumption that the underlying datasource accepts a SQL query. Can you remove this from the PR? The service may not accept SQL.

tdcmeehan · 2024-07-16T14:53:03Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowAbstractMetadata.java

+    public List<Field> getColumnsList(String schema, String table, ConnectorSession connectorSession)
+    {
+        try {
+            String dbSpecificSchemaName = getDBSpecificSchemaName(config, schema);


Avoid "DB" references as it might not be an underlying DB

I have removed "DB" references

tdcmeehan · 2024-07-16T14:53:44Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowTypeHandle.java

+            @JsonProperty("jdbcType") int jdbcType,
+            @JsonProperty("jdbcTypeName") String jdbcTypeName,


We can't have references to JDBC in this connector.

I have removed JDBC re references

steveburnett · 2024-07-16T17:11:46Z

Suggest change to the release note entry as follows:

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`

The documentation for Arrow Flight Connector appears to be being added in #23212 , so it doesn't need to be mentioned in this release note.

BryanCutler

I took a quick pass and had a few comments. I'll take another look at the rest a little later.

BryanCutler · 2024-07-17T00:44:34Z

presto-base-arrow-flight/pom.xml

+        <air.main.basedir>${project.parent.basedir}</air.main.basedir>
+        <grpc.version>1.53.0</grpc.version>
+        <dep.okhttp.version>4.10.0</dep.okhttp.version>
+        <arrow.version>11.0.0</arrow.version>


This is a fairly old version of Arrow, can you use a more recent one?

@BryanCutler I have updated to leastest arrow version

presto-base-arrow-flight/pom.xml

BryanCutler · 2024-07-17T01:04:20Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowColumnHandle.java

+    public ArrowColumnHandle(
+            @JsonProperty("columnName") String columnName,
+            @JsonProperty("columnType") Type columnType,
+            @JsonProperty("jdbcTypeHandle") ArrowTypeHandle arrowTypeHandle)


did you mean? "jdbcTypeHandle" -> "arrowTypeHandle"

BryanCutler · 2024-07-17T01:14:12Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowFlightClientHandler.java

+            return;
+        }
+        try {
+            RootAllocator allocator = new RootAllocator(Long.MAX_VALUE);


You would usually create a RootAllocator as a class member and they should be closed when not used anymore

@BryanCutler I have made changes for closing allocator

We are not re-using the flight client. The root allocator will be closed when ArrowFlightClient is closed or auto closed.

where is this RootAllocator closed then? The FlightClient creates a child allocator that is closed along with the client, it will not close the root

ArrowFlightClient saves the root allocator. The root allocator is closed when ArrowFlightClient is closed.

You wouldn't normally create a RootAllocator for each client, it could be reused as each client will internally make a child allocator. It's ok to clean that up later, since you are closing it here.

How would we determine when the root allocator should be closed? Should we keep track of open flight clients and close root allocator when there are no flight clients open for some duration of time?

I would create 1 RootAllocator for the connector and then close it during Connector.shutdown(). The FlightClient creates it's own child allocator that is closed with the client, so the root won't be keeping any buffers directly.

BryanCutler · 2024-07-17T01:16:21Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowFlightClientHandler.java

+                }
+            }
+
+            logger.debug("location %s", location.getUri().toString());


Is this meant to stay?

I have removed log @BryanCutler

BryanCutler · 2024-07-17T01:21:10Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowFlightClientHandler.java

+            trustedCertificate.get().close();
+        }
+        shutdownTimer();
+        isClientClosed.set(true);


Do the calls to getClient() and close() need to be thread-safe?

@BryanCutler I have addressed comments can please review changes

linux-foundation-easycla · 2024-07-17T06:10:26Z

The committers listed above are authorized under a signed CLA.

✅ login: sabbasani (f6d7870)

steveburnett

I reviewed the base-arrow-flight.rst documentation in #23212. If this documentation is to be included in this PR - which I think would be a good idea to do this - please address my comments in my most recent review in #23212 here.

tdcmeehan · 2024-07-24T20:15:28Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowQueryBuilder.java

+import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+
+public class ArrowQueryBuilder


This might better belong in a submodule that depends on this module which implements the Flight SQL spec. I don't think it belongs here.

@tdcmeehan I have addressed comments can please review changes

sabbasani · 2024-07-25T21:12:41Z

@tdcmeehan @BryanCutler @steveburnett
we have addressed all comments above.Can you please review

steveburnett

Thanks for the docs! Minor suggestions, mostly formatting.

A local doc build returns the following warning:

/Users/steveburnett/Documents/GitHub/presto/presto-docs/src/main/sphinx/connector/base-arrow-flight.rst: WARNING: document isn't included in any toctree

To address this warning,

Add connector/base-arrow-flight to
https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector.rst so the new page is present on the Connector page in the Presto documentation.
Add the new line in alphabetic order for the new page title Arrow-flight Connector.

presto-docs/src/main/sphinx/connector/base-arrow-flight.rst

steveburnett · 2024-07-29T16:12:08Z

Suggest update of the release note to include the PR number in both entries, and to link to the new doc from the release note.

== RELEASE NOTES ==

General Changes
* Add Arrow Flight connector :pr:`23032`
* Add documentation for the :doc:`/connector/base-arrow-flight`  :pr:`23032`

tdcmeehan · 2024-12-16T18:48:52Z

...e-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowFlightClientHandler.java

+
+public abstract class AbstractArrowFlightClientHandler
+{
+    private static final Logger logger = Logger.get(AbstractArrowFlightClientHandler.class);


Unused, please remove

tdcmeehan · 2024-12-16T18:49:56Z

...e-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowFlightClientHandler.java

+        return getFlightInfo(flightDescriptor, connectorSession).getSchemaOptional();
+    }
+
+    public void closeRootallocator()


closeRootAllocator

tdcmeehan · 2024-12-16T18:51:31Z

presto-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestingArrowFlightRequest.java

+import java.nio.charset.StandardCharsets;
+import java.util.Optional;
+
+public class TestingArrowFlightRequest


Remove all unused member variables in this class.

tdcmeehan · 2024-12-16T18:53:31Z

...e-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowFlightClientHandler.java

+
+    protected abstract CredentialCallOption[] getCallOptions(ConnectorSession connectorSession);
+
+    public ArrowFlightConfig getConfig()


There is no need for this method. Instead, implementors of this module can wire the config object where needed.

tdcmeehan · 2024-12-16T18:54:41Z

...e-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowFlightClientHandler.java

+        return config;
+    }
+
+    public ArrowFlightClient getClient(Optional<String> uri)


It seems we create clients per call. Create two methods, one that has a URI and one that doesn't, instead of this method with the optional URI parameter. Call it createArrowFlightClient or something along those lines.

tdcmeehan · 2024-12-16T18:58:33Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowSplit.java

+            @JsonProperty("ticket") byte[] ticket,
+            @JsonProperty("locationUrls") List<String> locationUrls)


Why not just embed the FlightEndpoint itself? It is serializable.

@tdcmeehan Tried making this Change in code and found that the FlightEndpoint is not serializable

It is serializable, here is the protobuf definition of it: https://github.com/apache/arrow/blob/main/format/Flight.proto#L439

tdcmeehan · 2024-12-16T19:00:37Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowSplitManager.java

+public abstract class AbstractArrowSplitManager
+        implements ConnectorSplitManager
+{
+    private static final Logger logger = Logger.get(AbstractArrowSplitManager.class);


Remove unused logger

tdcmeehan · 2024-12-16T19:09:30Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowMetadata.java

+        this.arrowBlockBuilder = requireNonNull(arrowBlockBuilder, "arrowPageBuilder is null");
+    }
+
+    protected abstract FlightDescriptor getFlightDescriptor(Optional<String> query, String schema, String table);


The query parameter is always empty. Do we need it?

Removed the query parameter

tdcmeehan · 2024-12-16T19:44:02Z

...-flight/src/test/java/com/facebook/plugin/arrow/TestingArrowServerUsingDictionaryVector.java

+
+            String schemaName = rootNode.get("interactionProperties").get("schema_name").asText(null);
+            String tableName = rootNode.get("interactionProperties").get("table_name").asText(null);
+            String selectStatement = rootNode.get("interactionProperties").get("select_statement").asText(null);
+
+            List<Field> fields = new ArrayList<>();
+            if (schemaName != null && tableName != null) {
+                String query = "SELECT * FROM INFORMATION_SCHEMA.COLUMNS " +
+                        "WHERE TABLE_SCHEMA='" + schemaName.toUpperCase() + "' " +
+                        "AND TABLE_NAME='" + tableName.toUpperCase() + "'";
+
+                try (ResultSet rs = connection.createStatement().executeQuery(query)) {
+                    while (rs.next()) {
+                        String columnName = rs.getString("COLUMN_NAME");
+                        String dataType = rs.getString("TYPE_NAME");
+                        String charMaxLength = rs.getString("CHARACTER_MAXIMUM_LENGTH");
+                        int precision = rs.getInt("NUMERIC_PRECISION");
+                        int scale = rs.getInt("NUMERIC_SCALE");
+
+                        ArrowType arrowType = convertSqlTypeToArrowType(dataType, precision, scale);
+                        Map<String, String> metaDataMap = new HashMap<>();
+                        metaDataMap.put("columnNativeType", dataType);
+                        if (charMaxLength != null) {
+                            metaDataMap.put("columnLength", charMaxLength);
+                        }
+                        FieldType fieldType = new FieldType(true, arrowType, null, metaDataMap);
+                        Field field = new Field(columnName, fieldType, null);
+                        fields.add(field);
+                    }
+                }
+            }
+            else if (selectStatement != null) {
+                selectStatement = selectStatement.toUpperCase();
+                logger.info("Executing SELECT query: " + selectStatement);
+                try (ResultSet rs = connection.createStatement().executeQuery(selectStatement)) {
+                    ResultSetMetaData metaData = rs.getMetaData();
+                    int columnCount = metaData.getColumnCount();
+
+                    for (int i = 1; i <= columnCount; i++) {
+                        String columnName = metaData.getColumnName(i);
+                        String columnType = metaData.getColumnTypeName(i);
+                        int precision = metaData.getPrecision(i);
+                        int scale = metaData.getScale(i);
+
+                        ArrowType arrowType = convertSqlTypeToArrowType(columnType, precision, scale);
+                        Field field = new Field(columnName, FieldType.nullable(arrowType), null);
+                        fields.add(field);
+                    }
+                }
+            }
+            else {
+                throw new IllegalArgumentException("Either schema_name/table_name or select_statement must be provided.");
+            }
+
+            Schema schema = new Schema(fields);
+            FlightEndpoint endpoint = new FlightEndpoint(new Ticket(flightDescriptor.getCommand()));
+            return new FlightInfo(schema, flightDescriptor, Collections.singletonList(endpoint), -1, -1);
+        }
+        catch (Exception e) {
+            logger.error(e);
+            throw new RuntimeException("Failed to retrieve FlightInfo", e);
+        }
+    }
+
+    @Override
+    public Runnable acceptPut(CallContext callContext, FlightStream flightStream, StreamListener<PutResult> streamListener)
+    {
+        throw new UnsupportedOperationException("This operation is not supported");
+    }
+
+    @Override
+    public void doAction(CallContext callContext, Action action, StreamListener<Result> streamListener)
+    {
+        try {
+            String jsonRequest = new String(action.getBody(), StandardCharsets.UTF_8);
+            JsonNode rootNode = objectMapper.readTree(jsonRequest);
+            String schemaName = rootNode.get("interactionProperties").get("schema_name").asText(null);
+
+            String query;
+            if (schemaName == null) {
+                query = "SELECT SCHEMA_NAME FROM INFORMATION_SCHEMA.SCHEMATA";
+            }
+            else {
+                schemaName = schemaName.toUpperCase();
+                query = "SELECT TABLE_NAME FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA='" + schemaName + "'";
+            }
+            ResultSet rs = connection.createStatement().executeQuery(query);
+            List<String> names = new ArrayList<>();
+            while (rs.next()) {
+                names.add(rs.getString(1));
+            }
+
+            String jsonResponse = objectMapper.writeValueAsString(names);
+            streamListener.onNext(new Result(jsonResponse.getBytes(StandardCharsets.UTF_8)));
+            streamListener.onCompleted();
+        }
+        catch (Exception e) {
+            streamListener.onError(e);
+        }
+    }


It seems like these are just copied from TestingArrowServer, but don't really apply to the test case where they're used. Can you make it simpler please, seems like this can just be hardcoded since it's not returning TPCH data.

Setting hardcoded values.

tdcmeehan · 2024-12-16T19:44:37Z

...-flight/src/test/java/com/facebook/plugin/arrow/TestingArrowServerUsingDictionaryVector.java

+        switch (sqlType.toUpperCase()) {
+            case "VARCHAR":
+            case "CHAR":
+            case "CHARACTER VARYING":
+            case "CHARACTER":
+            case "CLOB":
+                return new ArrowType.Utf8();
+            case "INTEGER":
+            case "INT":
+                return new ArrowType.Int(32, true);
+            case "BIGINT":
+                return new ArrowType.Int(64, true);
+            case "SMALLINT":
+                return new ArrowType.Int(16, true);
+            case "TINYINT":
+                return new ArrowType.Int(8, true);
+            case "DOUBLE":
+            case "DOUBLE PRECISION":
+            case "FLOAT":
+                return new ArrowType.FloatingPoint(FloatingPointPrecision.DOUBLE);
+            case "REAL":
+                return new ArrowType.FloatingPoint(FloatingPointPrecision.SINGLE);
+            case "BOOLEAN":
+                return new ArrowType.Bool();
+            case "DATE":
+                return new ArrowType.Date(DateUnit.DAY);
+            case "TIMESTAMP":
+                return new ArrowType.Timestamp(TimeUnit.MILLISECOND, null);
+            case "TIME":
+                return new ArrowType.Time(TimeUnit.MILLISECOND, 32);
+            case "DECIMAL":
+            case "NUMERIC":
+                return new ArrowType.Decimal(precision, scale);
+            case "BINARY":
+            case "VARBINARY":
+                return new ArrowType.Binary();
+            case "NULL":
+                return new ArrowType.Null();
+            default:
+                throw new IllegalArgumentException("Unsupported SQL type: " + sqlType);
+        }


Same comment--do you need this here at all? If not, please remove.

tdcmeehan · 2024-12-17T19:56:33Z

...e-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowFlightClientHandler.java

+
+    public Optional<Schema> getSchema(FlightDescriptor flightDescriptor, ConnectorSession connectorSession)
+    {
+        return getFlightInfo(flightDescriptor, connectorSession).getSchemaOptional();


I think this is problematic because this could involve the costly allocation of resources (like executing a query), only to discard the results and return the schema. I think we should use the GetSchema RPC on the flight client.

Updated to use getSchema RPC

tdcmeehan · 2024-12-17T21:42:08Z

presto-base-arrow-flight/src/test/java/com/facebook/plugin/arrow/TestingH2DatabaseSetup.java

+        Statement stmt = conn.createStatement();
+
+        // Create schema
+        stmt.execute("CREATE SCHEMA IF NOT EXISTS testdb");


Let's call this tpch instead.

Suggested change

stmt.execute("CREATE SCHEMA IF NOT EXISTS testdb");

stmt.execute("CREATE SCHEMA IF NOT EXISTS tpch");

Updated to use tpch

elbinpallimalilibm · 2024-12-18T15:28:11Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/AbstractArrowMetadata.java

+
+    private Type getPrestoTypeFromArrowField(Field field)
+    {
+        return arrowBlockBuilder.getPrestoTypeFromArrowField(field);


@tdcmeehan We are injecting an instance of ArrowBlockBuilder to re-use the arrow to presto field mappings.

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowPlugin.java

tdcmeehan · 2024-12-19T20:42:56Z

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowPlugin.java

+    protected final String name;
+    protected final Module module;
+
+    public ArrowPlugin(String name, Module module)


This won't work--plugins are loaded with ServiceLoaders, which require a no-arg constructor.

The implementing module will have to define the plugin like below.

public class MyArrowPlugin extends ArrowPlugin { public MyArrowPlugin() { super("my-arrow-flight", new MyArrowModule()); } }

Added TestingArrowPlugin to reference implementation in test to make this clear.

Co-authored-by: sai bhaskar reddy <sai.bhaskar.reddy.sabbasani1@ibm.com> Co-authored-by: SthuthiGhosh9400 <Sthuthi.Ghosh@ibm.com> Co-authored-by: lithinwxd <Lithin.Purushothaman@ibm.com> Co-authored-by: Steve Burnett <burnett@pobox.com> Co-authored-by: elbinpallimalilibm <elbin.pallimalil@ibm.com> Co-authored-by: Timothy Meehan <tim@timdmeehan.com>

sabbasani requested a review from a team as a code owner June 19, 2024 11:23

sabbasani requested a review from presto-oss June 19, 2024 11:23

sabbasani marked this pull request as draft June 19, 2024 11:42

tdcmeehan self-assigned this Jul 15, 2024

tdcmeehan requested changes Jul 16, 2024

View reviewed changes

tdcmeehan requested a review from BryanCutler July 16, 2024 14:55

BryanCutler reviewed Jul 17, 2024

View reviewed changes

steveburnett requested changes Jul 17, 2024

View reviewed changes

sabbasani force-pushed the arrow-connector branch 4 times, most recently from a69b92e to 7bd4ec9 Compare July 24, 2024 13:38

tdcmeehan reviewed Jul 24, 2024

View reviewed changes

sabbasani force-pushed the arrow-connector branch 8 times, most recently from 04cdc53 to 824175b Compare July 25, 2024 21:05

tdcmeehan requested a review from BryanCutler July 26, 2024 14:11

sabbasani force-pushed the arrow-connector branch from 6d9d75b to 11bada5 Compare July 29, 2024 13:16

steveburnett requested changes Jul 29, 2024

View reviewed changes

sabbasani force-pushed the arrow-connector branch from 3b73ee3 to c4e77f1 Compare July 29, 2024 17:28

elbinpallimalilibm force-pushed the arrow-connector branch 12 times, most recently from 39a50c8 to 4d247bc Compare December 14, 2024 10:14

tdcmeehan requested changes Dec 16, 2024

View reviewed changes

tdcmeehan reviewed Dec 16, 2024

View reviewed changes

tdcmeehan requested changes Dec 16, 2024

View reviewed changes

tdcmeehan requested changes Dec 17, 2024

View reviewed changes

tdcmeehan reviewed Dec 17, 2024

View reviewed changes

elbinpallimalilibm force-pushed the arrow-connector branch from d5ac984 to bb5b0f1 Compare December 18, 2024 11:18

elbinpallimalilibm reviewed Dec 18, 2024

View reviewed changes

elbinpallimalilibm force-pushed the arrow-connector branch 6 times, most recently from a9a9a50 to 57de3f1 Compare December 19, 2024 03:21

tdcmeehan requested changes Dec 19, 2024

View reviewed changes

presto-base-arrow-flight/src/main/java/com/facebook/plugin/arrow/ArrowPlugin.java Outdated Show resolved Hide resolved

tdcmeehan requested changes Dec 19, 2024

View reviewed changes

elbinpallimalilibm force-pushed the arrow-connector branch from bdabaec to 5d64ec1 Compare December 20, 2024 01:52

elbinpallimalilibm force-pushed the arrow-connector branch from 5d64ec1 to f6d7870 Compare December 20, 2024 02:14

		@JsonProperty("jdbcType") int jdbcType,
		@JsonProperty("jdbcTypeName") String jdbcTypeName,


		protected abstract CredentialCallOption[] getCallOptions(ConnectorSession connectorSession);

		public ArrowFlightConfig getConfig()

		@JsonProperty("ticket") byte[] ticket,
		@JsonProperty("locationUrls") List<String> locationUrls)

	stmt.execute("CREATE SCHEMA IF NOT EXISTS testdb");
	stmt.execute("CREATE SCHEMA IF NOT EXISTS tpch");

Arrow-flight connector #23032

Are you sure you want to change the base?

Arrow-flight connector #23032

Conversation

sabbasani commented Jun 19, 2024 • edited Loading

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

steveburnett commented Jun 19, 2024

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveburnett commented Jul 16, 2024

BryanCutler left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Jul 17, 2024 • edited Loading

steveburnett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabbasani commented Jul 25, 2024 • edited Loading

steveburnett left a comment

Choose a reason for hiding this comment

steveburnett commented Jul 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elbinpallimalilibm Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sabbasani commented Jun 19, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jul 17, 2024 •

edited

Loading

sabbasani commented Jul 25, 2024 •

edited

Loading

elbinpallimalilibm Dec 20, 2024 •

edited

Loading