Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a native function namespace manager #23358
base: master
Are you sure you want to change the base?
Add a native function namespace manager #23358
Changes from all commits
5eab56f
745c782
eeff0a5
35f7a48
3d9d985
4ca63ff
5567990
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need special logic to handle aggregation function intermediate types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need special logic to handle generic aggregate functions.
To resolve the intermediate type for generic aggregate functions, we rely on utility functions from TypeSignatureUtils. Specifically, we use the parameter types passed down in the function signatures to determine and insert the appropriate intermediateType.
This is required because aggregate function metadata for generic aggregate functions contain generic intermediate args i.e
K,V
and we need a way to resolve these args.Example:
max
function:For the max function, here is the relevant metadata:
In this case:
native.default.max(bigint):bigint
, we use the passed down param typebigint
to resolve the intermediate typet
asbigint
.max_by
function:In this case:
native.default.max_by(integer, boolean, bigint):array(integer)
, we use the passed down param typesinteger
to resolve the intermediate type"intermediateType": "row(bigint,array(boolean),array(v))
as"intermediateType": "row(bigint,array(boolean),array(integer))