-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presto-native-tests module #23671
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Reviewed README.md, no concerns. Thanks for the doc!
acaa071
to
8ec8208
Compare
Are these tests being run as part of the CI? |
They are not being run as part of CI currently, but we plan to setup a pipeline to run these tests on a regular cadence subsequently. Will also add a CI job to run these tests in a follow-up PR. |
public class TestAggregations | ||
extends AbstractTestAggregationsNative | ||
{ | ||
private static final String storageFormat = "PARQUET"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just testing parquet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the intention was to primarily test with parquet files. Most of the current e2e tests in presto-native-execution
test with DWRF format. We can extend this to test with other file formats going forward.
32b2ad6
to
f614cb6
Compare
11d653c
to
47ecc65
Compare
Just a suggestions for the release note: Consider using the description of the PR in the release note entry to help a release note reader understand what this module does.
|
Thanks for the suggestion @steveburnett, updated accordingly. |
47ecc65
to
ea94a86
Compare
|
a3552e4
to
c3e4729
Compare
364a2bd
to
31840cd
Compare
Co-authored-by: Manoj Negi <manojneg@in.ibm.com>
31840cd
to
c971a47
Compare
Description
Adds module
presto-native-tests
to run end-to-end tests with Presto native workers.Motivation and Context
Improves Presto native test coverage by extending production tests from
presto-tests
module to use the native worker.Contributor checklist