-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jackson's dependencies to address PRISMA-2023-0067 #23753
Conversation
|
e4bfb0c
to
6023bad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not a later version like 2.17.1?
I know @steveburnett disagrees with me about this, but I really don't think we should be including dependency upgrades in the release notes. |
Looks like the most recent version is 2.18.0 |
The CVS scan suggests upgrading to version 2.15.0, as that's where the vulnerability was fixed. But if we want the latest updates, we can go with 2.18.0. Let me know your preference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to go to the latest (honestly I'd prefer not to depend on jackson at all) but this is still an improvement.
@Mariamalmesfer @elharo Maybe we can update to the one version before the very latest which is |
Sounds good to me. We can go with 2.17.2 if that works for everyone. |
6531651
to
840291d
Compare
Please update the release note entry to the version being updated to. For example
|
I prefer 2.18.0 but I'm not sure others agree with this. Don't overthink it. Either 2.17.2 or 2.18 is better than what we have now. |
840291d
to
8a1d0b4
Compare
b0b5b17
to
de07533
Compare
ae11203
to
74b39c6
Compare
3ef9dcd
to
1961e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the entry in release note should be changed since you are not just upgrading jackson-core
here
cc @steveburnett
presto-jmx/src/main/java/com/facebook/presto/connector/jmx/JmxSplit.java
Outdated
Show resolved
Hide resolved
I agree @agrawalreetika, thank you! @Mariamalmesfer , please update the release note entry to describe the other changes you are making. Also, please include at least one of the CVEs addressed by this PR. For formatting of the link to the CVE, see the example in Phrasing in the Release Note Guidelines. Thanks! |
0918047
to
a25f1c7
Compare
two nits in the release note entry, looks good otherwise. Suggested edits below: == RELEASE NOTES == = Security Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last nit, otherwise looks good.
If applied, this will: Upgrade Jackson Core, Databind, and other dependencies to version 2.15.4. Address security vulnerabilities, including PRISMA-2023-0067.
d1eef37
to
fd9be63
Compare
Thanks for the release note entry update! Some minor nits of formatting in the release note entry - my bad, I should have put ``` before and after the draft in my previous comment to display the single `s in the draft.
|
Thank you @steveburnett! |
Description
This PR upgrades Jackson dependencies to version 2.15.4, addressing the security vulnerabilities identified in PRISMA-2023-0067.
Motivation and Context
Reasons for upgradation:
The upgrade to Jackson 2.15.4 resolves multiple critical security vulnerabilities, including a Denial of Service (DoS) vulnerability in jackson-core, caused by improper input validation during numeric type conversions. This update ensures enhanced security and system stability.
Impact
Image Scan showed the vulnerability have been removed.
Image scan report :
Image-scan-report-9 Sep.csv
Test Plan
Contributor checklist
Release Notes