-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Add flag to disable certificate verification #23780
[CLI] Add flag to disable certificate verification #23780
Conversation
fa9fff4
to
0aa72e5
Compare
Nit for release note entry for consistency with the Order of changes in the Release Notes Guidelines.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc, especially updating to capture other missing information that was not part of this PR! A minor nit of formatting, and otherwise looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good.
20336b6
to
c30c44e
Compare
Cherry-pick of trinodb/trino@1c5b9215a2d1b04b5f84e2b3e86 with minor modifications for Presto Co-authored-by: Lewuathe <lewuathe@me.com>
c30c44e
to
e56eda6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is really useful for development and local debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Description
Adds
--insecure
flag to the CLI to skip SSL certificate verification.This is a cherry-pick of trinodb/trino@1c5b9215a2d1b04b5f84e2b3e86 with modifications to allow it to compile within PrestoDB
Motivation and Context
When deploying presto behind an SSL-enabled proxy or configuring it directly using systems like kubernetes, the system will issue self-signed certificates which can make debugging more difficult when clients have not been properly configured with the CA. When debugging clusters which are deployed this way it would be useful to be able to connect to them directly by just bypassing certificate verification.
Impact
Additional flag for the CLI
Test Plan
Contributor checklist
Release Notes