Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removal of SessionPropertyManager loading #24181

Merged

Conversation

BryanCutler
Copy link
Contributor

The previous commit to add the native plan checker mistakenly removed the loading of SessionPropertyManager. This adds back the call to loadSessionPropertyProviders() into PrestoServer.

See #23596

Description

Motivation and Context

Reverting change needed to load session property providers.

Impact

Session property providers will not be properly loaded.

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

== NO RELEASE NOTE ==


The previous commit to add the native plan checker mistakenly removed
the loading of SessionPropertyManager. This adds it back the call to
loadSessionPropertyProviders into PrestoServer.

See prestodb#23596
@BryanCutler BryanCutler requested a review from a team as a code owner December 3, 2024 06:00
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 3, 2024
@prestodb-ci prestodb-ci requested review from a team, aaneja and zuyu and removed request for a team December 3, 2024 06:00
@BryanCutler BryanCutler merged commit 0213802 into prestodb:master Dec 3, 2024
57 checks passed
@BryanCutler BryanCutler deleted the revert-session-property-manager branch December 3, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants