Update commons-dbcp2 version to fix common vulnerabilities and exposures #24249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
ShahimSharafudeen and
Dilli-Babu-Godari
and removed request for
a team
bibith4
force-pushed
the
oss_cve_commons_dbcp2_fix
branch
3 times, most recently
from
c37e6d4 to
e79aaaf
Compare
bibith4
changed the title
bibith4
force-pushed
the
oss_cve_commons_dbcp2_fix
branch
from
18e1398 to
e79aaaf
Compare
This is the commit message prestodb#2: Update commons-dbcp2 version to fix common vulnerabilities and exposures Update commons-dbcp2 version to fix common vulnerabilities and exposures
bibith4
force-pushed
the
oss_cve_commons_dbcp2_fix
branch
from
f7a2c17 to
0bc5315
Compare
|
@bibith4 I noticed that the latest version of commons-dbcp2 is available. Is there any issue with using that version? |
|
@bibith4 LGTM |
@Dilli-Babu-Godari Recent version 2.13 was released on December 2, 2024. To ensure stability, I opted to use commons-dbcp2 version 2.12, which was released earlier on March 4, 2024 |
|
@bibith4 LGTM |
Dilli-Babu-Godari
approved these changes
Dec 16, 2024
ShahimSharafudeen
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to upgrade commons-dbcp2 versions in from presto-pinot-toolkit and presto-product-tests to remove vulnerabilities.
Motivation and Context
The presto-pinot-toolkit and presto-product-tests have interdependencies with commons-dbcp2 versions 2.6.0 and 2.1, respectively, both of which contain vulnerabilities. These vulnerabilities can be removed by upgrading the commons-dbcp2 dependency to 2.12.0.
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.