Add DeleteNode to presto_protocol serialization #24274
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds basic support for DeleteNode to presto_protocol serialization. This is required for DELETE statement plans to be passed through to Prestissimo workers.
Motivation and Context
This is the first step in adding DELETE query plan support to Prestissimo/Velox, by supporting basic serialization of the Java
com.facebook.presto.spi.plan.DeleteNode
class and members. While this includes basic (de)serialization, the generatedprotocol::DeleteNode
class is not yet hooked up to any connectors. Conversion to Velox Hive Connector types will follow in a subsequent PR.Impact
DeleteNode has been added to presto_protocol so it is now available for use by Prestissimo connector implementations.
Test Plan
A basic test, DeleteTest.cpp, is included, which validates round-trip serialization of a sample DeleteNode representation.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.