Add "native_expression.max_compiled_regexes" session property. #24282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spershin
requested review from
steveburnett,
elharo and
a team
as code owners
zation99
reviewed
Dec 18, 2024
...n/java/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
Outdated
Show resolved
Hide resolved
spershin
force-pushed
the
Add_max_compiled_regexes_SessionProp
branch
from
ae04ea5 to
2a37c35
Compare
zation99
approved these changes
Dec 18, 2024
rschlussel
approved these changes
Dec 19, 2024
| NATIVE_EXPRESSION_MAX_COMPILED_REGEXES, | ||
| "Native Execution only. Controls maximum number of compiled regular expression patterns " + | ||
| "per regular expression function instance per thread of execution.", | ||
| 100, |
There was a problem hiding this comment.
looks to be standard for all nativeWorkerSessionProperties, so not requesting a change. but why do we define a default value in the session property vs. have the default value be determined by a config property like we do with everything else.
There was a problem hiding this comment.
I believe because there is no corresponding config property.
Not sure if one must have such.
There is just a corresponding velox query config property, which is per query.
arhimondr
approved these changes
Dec 19, 2024
amitkdutta
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add "native_expression.max_compiled_regexes" session property.
It can be used to control the limitation of Prestissimo's implementation of regular expression functions.