Support Hudi merged view files for partition path updates without compaction #24283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacBlanco
reviewed
Dec 20, 2024
| @@ -1647,6 +1648,19 @@ public boolean isHudiMetadataEnabled() | |||
| return this.hudiMetadataEnabled; | |||
| } | |||
|
|
|||
| @Config("hive.hudi-tables-use-merged-view") | |||
| @ConfigDescription("For Hudi tables prefer to fetch the list of files from the merged file system view") | |||
There was a problem hiding this comment.
I think the description should be more clear about the type of value it's looking for. The type is a string, so for users it should be more explicit what the value should be. When I read this I initially thought it should be a boolean.
Based on looking at the tests it looks like it needs a dot-separated name of schema and table? If so, it should be clear about which tables should be added here
Suggested change
| @ConfigDescription("For Hudi tables prefer to fetch the list of files from the merged file system view") | |
| @ConfigDescription("For Hudi tables, A comma-separated list in the form of <schema>.<table> which should prefer to fetch the list of files from the merged file system view") |
| @@ -608,6 +609,11 @@ public HiveSessionProperties(HiveClientConfig hiveClientConfig, OrcFileWriterCon | |||
| "For Hudi tables prefer to fetch the list of file names, sizes and other metadata from the internal metadata table rather than storage", | |||
| hiveClientConfig.isHudiMetadataEnabled(), | |||
| false), | |||
| stringProperty( | |||
| HUDI_TABLES_USE_MERGED_VIEW, | |||
| "For Hudi tables, use merged view to read data", | |||
There was a problem hiding this comment.
please update the description here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Hudi merged view files for partition path updates without compaction. This is needed with Merge-on-Read Hudi tables when partition has been updated for a record and the table has not been compacted yet.
schemaName.tableName) where this support is needed.HudiDirectoryLister.Motivation and Context
Support Hudi merged view files for partition path updates without compaction. This is needed with Merge-on-Read Hudi tables when partition has been updated for a record and the table has not been compacted yet.
Impact
Support Hudi merged view files for partition path updates without compaction. This is needed with Merge-on-Read Hudi tables when partition has been updated for a record and the table has not been compacted yet. As a result, even the read-optimized view of Merge-on-Read tables under partition path updates without compaction should not return any duplicates.
Test Plan
Contributor checklist
Release Notes