Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg]Fix flaky caused by rename view test #24292

Merged

Conversation

hantangwangd
Copy link
Member

Description

Fix #24290

The newly added test method testRenameView() in TestIcebergMetadataListing create tables and views in an existing schema who's metadata would be read and validated in another test method testTableColumnListing(). This will lead to flaky when they are running concurrently in multi-thread environment.

This PR use a dedicated schema in testRenameView(), in this way fix the flaky issue.

Motivation and Context

Fix #24290

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd requested review from ZacBlanco and a team as code owners December 20, 2024 17:45
@hantangwangd hantangwangd force-pushed the fix_rename_view_flaky_test branch from dfb24ee to 565034d Compare December 21, 2024 01:18
@hantangwangd hantangwangd merged commit eae4696 into prestodb:master Dec 21, 2024
57 checks passed
@hantangwangd hantangwangd deleted the fix_rename_view_flaky_test branch December 21, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: TestIcebergMetadataListing.testTableColumnListing
3 participants