[native] Add support shuffle compression for Prestissimo #24295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoxmeng
commented
Dec 22, 2024
xiaoxmeng
commented
xiaoxmeng
force-pushed
the
session
branch
2 times, most recently
from
cb113ba to
c97524a
Compare
tanjialiang
previously approved these changes
Dec 23, 2024
| @@ -283,6 +283,10 @@ class SessionProperties { | |||
| static constexpr const char* kPrefixSortMinRows = | |||
| "native_prefixsort_min_rows"; | |||
|
|
|||
| /// If true, enable the shuffle compression. | |||
| static constexpr const char* kShuffleCompressionEnabled = | |||
| "exchange_compression"; | |||
There was a problem hiding this comment.
This is a java session
| } else if (it.first == SessionProperties::kShuffleCompressionEnabled) { | ||
| if (it.second == "true") { | ||
| configs[core::QueryConfig::kShuffleCompressionKind] = std::to_string( | ||
| static_cast<uint32_t>(velox::common::CompressionKind_LZ4)); |
There was a problem hiding this comment.
We default to use lz4? Do we want to provide options for compression kind as well?
There was a problem hiding this comment.
Java is hard coded. I put comment there.
tanjialiang
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.