Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Make a noisy log VLOG. #24311

Merged
merged 1 commit into from
Jan 1, 2025
Merged

[native] Make a noisy log VLOG. #24311

merged 1 commit into from
Jan 1, 2025

Conversation

amitkdutta
Copy link
Contributor

Description

Making a noisy log VLOG to keep logs clean.

Motivation and Context

Observed in production that almost ~50% logs are pointing to one log line. Making it to VLOG.

grep -nir "Failed to update output buffers" log_file | wc -l
78722
cat log_file | wc -l
178964

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested a review from a team as a code owner January 1, 2025 03:27
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 1, 2025
xiaoxmeng
xiaoxmeng approved these changes Jan 1, 2025
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitkdutta LGTM. Thanks

@xiaoxmeng xiaoxmeng merged commit 08cf9bb into prestodb:master Jan 1, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

Assignees
No one assigned
Labels
from:Meta PR from Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitkdutta @xiaoxmeng @prestodb-ci