Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Improve an error message. #24332

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

amitkdutta
Copy link
Contributor

Description

Improve error message for better debugging

Motivation and Context

Sometimes we get empty response in httpclient. The error message looks like Heartbeat failed: HTTP 404 -. Its better to explicitly print empty response to be clear. New message is Heartbeat failed: HTTP 404 - Empty response

== NO RELEASE NOTE ==

@amitkdutta amitkdutta requested a review from a team as a code owner January 8, 2025 02:02
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 8, 2025
Copy link
Contributor

@gggrace14 gggrace14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me!

@amitkdutta amitkdutta merged commit e2bb5c2 into prestodb:master Jan 8, 2025
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants