[native] Advance Velox #24339
Merged
[native] Advance Velox #24339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aditi-pandit
commented
Jan 9, 2025
aditi-pandit
commented
prestodb-ci
requested review from
a team,
czentgr and
psnv03
and removed request for
a team
aditi-pandit
changed the title
aditi-pandit
force-pushed
the
advance_velox
branch
from
809174e to
4703757
Compare
|
presto_server linked libraries are updated as they were removed from velox_hive_connector dependencies in facebookincubator/velox#11956 |
aditi-pandit
changed the title
majetideepak
previously approved these changes
Jan 9, 2025
|
@aditi-pandit Let's wait until #24331 is merged. |
|
@aditi-pandit There are link issues for macOS and Linux besides the disk space issues. So these need to be looked into. We merged the disk space issue fix. Please rebase and maybe update Velox again? |
|
@majetideepak and @czentgr : Alright. Updating again. |
aditi-pandit
force-pushed
the
advance_velox
branch
from
4703757 to
757c8ac
Compare
aditi-pandit
force-pushed
the
advance_velox
branch
from
757c8ac to
da2890a
Compare
|
@majetideepak : Bunch more changes were needed for the linking of presto types tests as well. Please can you review once more. |
czentgr
approved these changes
Jan 9, 2025
majetideepak
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.