[PLATFORM-1473] Support opentelemetry 0.21 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiemontese
reviewed
Mar 8, 2024
There was a problem hiding this comment.
I like the approach, because it gives us a way to release the latest version of the otel deps but lets users rollback on their own if it doesn't work
I think we should limit the supported versions and not end up like the actix library, but it's a matter of "discipline"
Is there a README to update detailing this a bit? I.e. that we support two version and they can be used like so and blah blah
cpiemontese
previously approved these changes
Mar 8, 2024
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - Support for opentelemetry 0.21 | ||
| - `tracing_opentelemetry_0_21` and `tracing_opentelemetry_0_21` features |
There was a problem hiding this comment.
I don't understand the difference 🤔
cpiemontese
previously approved these changes
Mar 8, 2024
cpiemontese
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-1473/Support-opentelemetry-0.21